Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run unit tests #308

Merged
merged 10 commits into from
Oct 5, 2024
Merged

ci: Run unit tests #308

merged 10 commits into from
Oct 5, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Sep 24, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger label Sep 24, 2024
@github-actions github-actions bot added the CI label Sep 24, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Sep 24, 2024
Signed-off-by: Oliver Koenig <[email protected]>
f
Signed-off-by: Oliver Koenig <[email protected]>
f
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/unit-tests branch from ae54d54 to 642a779 Compare September 25, 2024 15:47
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Sep 25, 2024
@ko3n1g ko3n1g marked this pull request as ready for review September 25, 2024 18:10
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Sep 25, 2024
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Sep 25, 2024
Signed-off-by: Terry Kong <[email protected]>
@terrykong terrykong mentioned this pull request Oct 1, 2024
8 tasks
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 1, 2024
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Oct 1, 2024
@ko3n1g ko3n1g requested a review from gshennvm October 1, 2024 11:39
@ko3n1g ko3n1g enabled auto-merge (squash) October 1, 2024 11:39
Dockerfile Outdated Show resolved Hide resolved
f
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g disabled auto-merge October 3, 2024 18:20
@terrykong
Copy link
Collaborator

@ko3n1g could you resolve DCO, then we can merge

@ko3n1g ko3n1g merged commit c92a3bf into main Oct 5, 2024
5 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/unit-tests branch October 5, 2024 08:01
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 7, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Co-authored-by: Terry Kong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants