Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Improve caching #301

Merged
merged 3 commits into from
Sep 23, 2024
Merged

build: Improve caching #301

merged 3 commits into from
Sep 23, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Sep 22, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g requested a review from terrykong September 22, 2024 03:01
@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger label Sep 22, 2024
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Sep 22, 2024
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g removed the Run CICD Set + un-set to retrigger label Sep 22, 2024
@ko3n1g ko3n1g marked this pull request as ready for review September 22, 2024 08:38
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Sep 22, 2024

Hey @terrykong, this fixes the last issues to help with reliable caching. Unfortunately, it doesn't help super much as TRTLLM is the most expensive part (and follows Aligner). Let's still merge it since it's the right way of ensuring caching

@ko3n1g ko3n1g merged commit f8f7a55 into main Sep 23, 2024
5 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/cache branch September 24, 2024 08:09
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant