Ring Allgather + GEMM Overlap HostIR Implementation #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarka
commented
Dec 20, 2024
| for ([[maybe_unused]] const auto& _ : | ||
| c10::irange(params.number_of_iterations)) { | ||
| // I don't know why but this seems necessary... | ||
| at::manual_seed(getATenRandomSeed()); |
There was a problem hiding this comment.
I spent a while before realizing that without this line, the test fails with a data validation error. I pasted the line from one of Sam's tests (comment included)
nsarka
force-pushed
the
nsarka/ring-ag-overlap-hostir
branch
from
3f3c77a to
a9ef116
Compare
|
!build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the HostIR version of the Ring AG+GEMM overlap scheme. It also has some minor code-cleanliness updates to the ATen version.