Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slackdown to Reactive Balance #1202

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add slackdown to Reactive Balance #1202

merged 1 commit into from
Dec 17, 2024

Conversation

rodrigomha
Copy link
Contributor

Closes #1168

@rodrigomha rodrigomha requested a review from jd-lara December 17, 2024 17:49
@rodrigomha rodrigomha self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (9ce3aa8) to head (1c32fae).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   77.24%   77.15%   -0.10%     
==========================================
  Files         121      121              
  Lines       13418    13419       +1     
==========================================
- Hits        10365    10353      -12     
- Misses       3053     3066      +13     
Flag Coverage Δ
unittests 77.15% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/network_models/network_constructor.jl 92.77% <100.00%> (+0.08%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

Performance Results

Version Precompile Time
Main 4.143872404
This Branch 4.182758982
Version Build Time
Main-Build Time Precompile 67.005749457
Main-Build Time Postcompile 1.032923138
This Branch-Build Time Precompile 64.577283992
This Branch-Build Time Postcompile 0.964751902
Version Solve Time
Main-Solve Time Precompile 888.340101375
Main-Solve Time Postcompile 855.183671915
This Branch-Solve Time Precompile 446.614925227
This Branch-Solve Time Postcompile 400.630451809

@jd-lara jd-lara merged commit 2829eeb into main Dec 17, 2024
10 of 11 checks passed
@jd-lara jd-lara deleted the rh/fix_reactiveslack branch December 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slackdown is not added to bus Q balance
2 participants