[1pt] PR: Bug fixes for test_cases #1387
Open
+61
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues in test_cases:
synthesize_test_cases
andrun_test_case
if any directories of the 5 benchmark sources (BLE, NWS, IFC, USGS, or ras2fim) do not exist. This issue was originally discovered and fixed in [1pt] WIP PR: Create inputs for selected HUC(s) #1178, but is being elevated to its own PR here. Fixes [1pt] Error in evaluation if a benchmark folder is missing #1386.run_test_cases
to accommodate levee and waterbody masking in Alaska. As part of these changes, hardcoded paths were replaced by environment variables.Changes
src/bash_variables.env
: Added environment variables for Alaska waterbody and levee masks and two variables to replace fixed paths in an upcoming PR ([1pt] WIP PR: Create inputs for selected HUC(s) #1178).tools/
run_test_case.py
: Fixed error if missing validation data. Updated masking data to include Alaska.synthesize_test_cases.py
: Fixed error if missing validation data.Testing
Ran
synthesize_test_cases.py
with-m
option to create metrics on atest_cases
folder that was missing IFC data.Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)