Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] PR: Fixed osmid and added huc column #1360

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ZahraGhahremani
Copy link
Contributor

@ZahraGhahremani ZahraGhahremani commented Dec 6, 2024

Fixed missing osmid in osm_bridge_centroid.gpkg. Also, HUC column is added to outputs.

Changes

  • data/bridges/pull_osm_bridges.py
  • src/aggregate_by_huc.py

Testing

ran fim_pipeline for HUC01010010.
pulled osm data successfully for HUC 18070304.

Deployment Plan (For developer use)

Bridge data input needs to be updated.

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • [NA ] New functions are documented (with a description, list of inputs, and expected output)
  • [ NA] Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@ZahraGhahremani ZahraGhahremani changed the title Fixed osmid and added huc column [5pt] PR: Fixed osmid and added huc column Dec 6, 2024
@ZahraGhahremani ZahraGhahremani added bug Something isn't working enhancement New feature or request labels Dec 6, 2024
@ZahraGhahremani ZahraGhahremani linked an issue Dec 6, 2024 that may be closed by this pull request
@ZahraGhahremani ZahraGhahremani marked this pull request as ready for review December 6, 2024 23:27
@AliForghani-NOAA
Copy link
Collaborator

I executed data/bridges/pull_osm_bridges.py using the CONUS HUC8 file, which generated approximately 715K OSM bridges. There were no missing osmid values, and the HUC column was correctly added. So, this PR is approved.

I observed that for bridges spanning two HUC8 regions, a single osmid appears as two separate records for each HUC8, as shown below. For the lidar-informed bridge workflow, we may need to address this issue in the future.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5pt] Bug and updates to huc level osm_bridge_centroids.gpkg
3 participants