-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3pt] PR: Docker, python packages and jdk updates #1217
Conversation
@mluck When you test this PR, keep this image. I have another small PR coming that I would like tested against this image so both can be merged at once. (if that is ok) |
I built the image from It looks like Whitebox is still trying to download the executable, unless these are just being printed to the screen.
A warning:
A lot of these warnings:
A couple of these warnings:
|
But.. there are so many warnings, we may want to cleanup some of the current warnings (pre this release) and new warning post this release), only in the name of sheer volume, I am open to suggestions. The biggest driver on getting this out, is that both ITSG and depbot are wanting this merge sooner than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. The warnings don't affect the functionality of the scripts.
This PR rolls up a bunch of other PR's and python packages requests including:
Other tasks included are:
unit_test
system, including the packagepytest
. This included some changes to theCONTRIBUTING.md
document.pluggy
andiniconfig
config/aws_s3_put_fim3_hydrovis_whitelist.lst
fim_post_processing.sh
pyproject.toml
. (line length was not working correctly)Changes
Dockerfile
,Pipfile
,Pipfile.lock
: as describe above for python package changes.gitignore
,CONTRIBUTING.md
: File changes related to removing theunit_test
system.fim_post_processing.sh
: noted above.pyproject.toml
: fixes and updates for lintingRemovals
unit_tests
folder and all related files under it. Appx 25 to 30 files removed.Testing
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally/foss_fim/
, run:pytest unit_tests/
)4.x.x.x
Merge Checklist (For Technical Lead use only)