Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRP FIM Symbology & Legend Update #1009 #1017

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

GeorgeRought-NOAA
Copy link
Contributor

@GeorgeRought-NOAA GeorgeRought-NOAA commented Dec 19, 2024

A request was made to change the AEP (NRP) FIM symbology to be less similar to the categorical FIM service. The color scheme was changed to resemble the symbology of the high flow magnitude FIM. The legend terminology was also updated from "AEP" to "NRP". Changes were isolated to this .mapx file.

Additions

Removals

Changes

New Color Values:

2%
FF00E5
4%
9E00FF
10%
1400FF
20%
2D9FFF
50%
39EFFF
50%
B4FFF2

Legend Terminology changed from "AEP" to "NRP"

Testing

Screenshots

image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link

@LorneLeonard-NOAA LorneLeonard-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. George found a good test location. Thank you Shawn for helping us debug.

Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Way to make quick work of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task 3 GAMA Task 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRP (AEP) Service Color Scheme Needs Update
3 participants