Functional updates to R package - improved user options & record nhdplusTools retrieval metadata #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o modular functions inside package
describe the unique dependencies
…fix associated functions when behavior didn't follow expected behavior
…_train_eval module
…go_train_eval module; feat: move some hard-coded variables into the algorithm config file
… documentation using fs instead of fsds
…ture needs to be created to allow local_paths
…aset size before pull
…aset size before pull
…in quotes. Does not affect how R reads yaml file
…onfig_opt(), default assign hydrofabric retrieval as optional
…h latest hydrofabric arguments
…fab_config_opt unit testing
…t, summarise, n_distinct
…efine a glue/f-string formatted path structure in config files
|
@lbolotin - ready for review! The latest change reworked how the attribute metadata containing the comid is saved and loaded in R, and read in via python. |
|
Closing this PR because it is stuck on "Processing updates" and isn't showing the last couple commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the script
fs_attrs_grab.Rto argparse a user-config file and easily run in command line.Modify
proc_attr_wrapto allow user-specified hydrofabric arguments when callinghfsubsetR::get_subset()by creatinghfab_config_optProvide user-option to not acquire hydrofabric data (
hfab_retr=FALSE)Add arguments in attribute config file corresponding to aforementioned features.
Create .csv download of nldi features generated by nhdplusTools
Additions
Create
hfab_config_opt()to auto-generate arguments forhfsubsetR::get_subset()if not provided, and create associated unite test. Modified the scriptfs_attrs_grab.Rto runhfab_config_opt.Add arguments in attribute config file corresponding to configuring
hfsubsetR::get_subset()Create .csv download of nldi features generated by
nhdplusTools, saving inside the user_data_std/dataset directory, with the filename following the standard formatglue::glue('nldi_feat_{dataset_name}.csv'). This file will be useful for results/plots.Removals
Changes
Modify the script
fs_attrs_grab.Rto argparse a user-config file and easily run in command line.Modify
proc_attr_wrapto allow user-specified hydrofabric arguments when callinghfsubsetR::get_subset(). Defaulthfab_retr=FALSEmeans skip downloading hydrofabric data.Testing
"hfab_config_opt"Screenshots
Notes
Todos
Checklist
Testing checklist
Many unit tests for
proc.attr.hydfabwill continue to fail until the attribute data in the hydrofabric s3 bucket becomes publicly available, and once version 2.2 of the hydrofabric becomes publicly available.Target Environment support
Accessibility
Other