[uwtools_integration] Integrate ics/lbcs #266

WeirAE · 2024-09-19T15:28:53Z

DESCRIPTION OF CHANGES:

A full integration of uwtools for the make_ics and make_lbcs tasks.

All fundamental tests have passed

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

TESTS CONDUCTED:

hera.intel
fundamental test suite

… into integrate_ics_lbcs

scripts/chgres_cube.py

maddenp-noaa

I think there might be some changes coming, and will re-review after those. Maybe some changes suggested in this batch of comments will appear, too.

scripts/chgres_cube.py

parm/wflow/coldstart.yaml

scripts/chgres_cube.py

ush/config_defaults.yaml

…_ics_lbcs

christinaholtNOAA · 2024-10-31T16:44:38Z

Hi all, let's hold off on reviews for the moment. I'm going to push some changes. We'll let you know when it's ready for the next round of review.

Updates for make_ics/make_lbcs. Fundamental tests pass.

parm/wflow/coldstart.yaml

scripts/chgres_cube.py

Co-authored-by: Paul Madden <[email protected]>

I have started working on the PR, so my change request is no longer valid.

Updates to make_ics/make_lbcs.

WeirAE and others added 11 commits August 21, 2024 13:39

initial chgres_cube config

6bdab4c

update coldstart.yaml

46a3227

second pass on passing files

1af2517

progress continues adding functionality

b7884cc

update secondary YAML logic

b188301

first version edits complete

4753089

config_defaults.yaml formatting fixes

93ac362

yaml fixes to complete build

e437b3d

try some changes in chgres_cube.py

bee31be

add changes from PR 264

e661d1c

Merge branch 'uwtools_integration' into integrate_ics_lbcs

7360ec1

WeirAE self-assigned this Sep 19, 2024

WeirAE added 7 commits September 19, 2024 11:30

revert unintended changes

ed58157

also revert utils.py

8dde45f

Revert remaining formatting

9f16342

fix local issues

d6c3786

fix YAML formatting

4eff96a

Fix remaining YAML syntax issues

3b65a6c

Undo prior incorrect sync and refix YAML

7116141

WeirAE force-pushed the integrate_ics_lbcs branch from 51c05a0 to 3b65a6c Compare September 20, 2024 15:04

WeirAE added 10 commits September 20, 2024 16:22

local YAML and path fixes

c310cb8

progress resolving dereferencing

9a0ab65

fixes for loop logic

226d335

fixes for lbcs

8a3ed18

fix external model yaml issues

8b7dd87

Merge remote-tracking branch 'refs/remotes/origin/integrate_ics_lbcs'…

2f709e3

… into integrate_ics_lbcs

move tracers to external_model_defaults

b83c5af

significant logic changes

d9701bf

Fix file copy logic

fc59204

fix output directories

12fb677

christinaholtNOAA reviewed Oct 25, 2024

View reviewed changes

scripts/chgres_cube.py Outdated Show resolved Hide resolved

maddenp-noaa reviewed Oct 28, 2024

View reviewed changes

scripts/chgres_cube.py Show resolved Hide resolved

parm/wflow/coldstart.yaml Outdated Show resolved Hide resolved

parm/wflow/coldstart.yaml Outdated Show resolved Hide resolved

scripts/chgres_cube.py Outdated Show resolved Hide resolved

NaureenBharwaniNOAA reviewed Oct 29, 2024

View reviewed changes

scripts/chgres_cube.py Outdated Show resolved Hide resolved

ush/config_defaults.yaml Outdated Show resolved Hide resolved

WeirAE force-pushed the integrate_ics_lbcs branch from 70bdfb4 to 25fd2b4 Compare October 29, 2024 21:50

WeirAE added 7 commits October 29, 2024 22:04

Merge remote-tracking branch 'gsl/uwtools_integration' into integrate…

1460cff

…_ics_lbcs

add back several changes lost in conflict resolutions

0e2f6e0

additional residual formatting fixes

093fbf0

fixes for running

affa5d4

Additional fixes

d74b410

move file handling to external_model_defaults.yaml

86db971

clean dereferencing, fix file errors

d9488d9

WeirAE requested review from maddenp-noaa, christinaholtNOAA and NaureenBharwaniNOAA October 31, 2024 14:33

found missing file path

fb398c0

christinaholtNOAA and others added 2 commits November 1, 2024 14:20

Updates for make_ics/make_lbcs. Fundamental tests pass.

bedeb67

Merge pull request #1 from christinaholtNOAA/chgres_cube_changes

396a321

Updates for make_ics/make_lbcs. Fundamental tests pass.

maddenp-noaa reviewed Nov 1, 2024

View reviewed changes

WeirAE and others added 6 commits November 1, 2024 11:24

Apply suggestions from code review

9da027b

Co-authored-by: Paul Madden <[email protected]>

Additional changes from comments

43fedf3

WIP.

4e55694

Run black.

ef9f299

Updates to scripts.

da4b988

Apply black.

e86eb94

Merge pull request #2 from christinaholtNOAA/update_chgres

1d28136

Updates to make_ics/make_lbcs.

maddenp-noaa approved these changes Nov 4, 2024

View reviewed changes

christinaholtNOAA merged commit 4ce6ecb into NOAA-GSL:uwtools_integration Nov 4, 2024

WeirAE mentioned this pull request Nov 5, 2024

Integrate drivers for make_ics/make_lbcs: Part II ufs-community/uw-team#1

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[uwtools_integration] Integrate ics/lbcs #266

[uwtools_integration] Integrate ics/lbcs #266

WeirAE commented Sep 19, 2024 •

edited

Loading

maddenp-noaa left a comment

christinaholtNOAA commented Oct 31, 2024

[uwtools_integration] Integrate ics/lbcs #266

[uwtools_integration] Integrate ics/lbcs #266

Conversation

WeirAE commented Sep 19, 2024 • edited Loading

DESCRIPTION OF CHANGES:

Type of change

TESTS CONDUCTED:

maddenp-noaa left a comment

Choose a reason for hiding this comment

christinaholtNOAA commented Oct 31, 2024

WeirAE commented Sep 19, 2024 •

edited

Loading