Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Utils and PathBuilder mods #85

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

HTTP Utils and PathBuilder mods #85

wants to merge 12 commits into from

Conversation

paulhamer-noaa
Copy link
Contributor

Linear Issue

IDSSE-1001

Changes

  • Introduce a HTTP utils based on the aws_utils implementation
  • Update pathbuilder to not fail when parsing file paths that do not conform to expected format

Explanation

Required supporting code for MRMS observation data ingest from NSSL directly

@paulhamer-noaa
Update pathbuilder to handle filepaths missing expected format elements
10ea6d3 
Create a generic HTTP class based on the aws_utils with similar issue/valid time handling
to deal with possible observation datasets.
@paulhamer-noaa
pylint cleanup
0294b56
Geary-Layne
Geary-Layne requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Geary-Layne Geary-Layne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't how much is in common with aws_utils, but if there is a sufficient about it would be better to create a base class for whatever is common and extend for aws and http

python/idsse_common/idsse/common/http_utils.py Outdated Show resolved Hide resolved
python/idsse_common/idsse/common/path_builder.py Outdated Show resolved Hide resolved
python/idsse_common/idsse/common/http_utils.py Outdated Show resolved Hide resolved
python/idsse_common/idsse/common/http_utils.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geary-Layne Geary-Layne Geary-Layne requested changes

@mackenzie-grimes-noaa mackenzie-grimes-noaa mackenzie-grimes-noaa left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulhamer-noaa @Geary-Layne @mackenzie-grimes-noaa