Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/idsse 602/name changes #56

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Chore/idsse 602/name changes #56

merged 3 commits into from
Mar 1, 2024

Conversation

Geary-Layne
Copy link
Contributor

Linear Issue

IDSSE-602

Changes

  • This is a companion to the PR for DAS

    • Changed region abbreviation to full words

  • There is also changed to address that fact that python is deprecating timezone naive datetime

    • I'm seeing these warning since I've switched to python 3.12

Explanation

N/A

@Geary-Layne Geary-Layne self-assigned this Feb 29, 2024
mackenzie-grimes-noaa
mackenzie-grimes-noaa approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mackenzie-grimes-noaa mackenzie-grimes-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is at worst harmless, at best helpful and informative for future readers.

Anyone at all familiar with NWP may have understood "CO" means "CONUS", but this way everyone is on the same level.

@Geary-Layne Geary-Layne merged commit 0f2b01f into main Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackenzie-grimes-noaa mackenzie-grimes-noaa mackenzie-grimes-noaa approved these changes

Assignees

@Geary-Layne Geary-Layne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geary-Layne @mackenzie-grimes-noaa