-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for Rocky8 (rt) #57
Conversation
@@ -20,6 +20,7 @@ | |||
echo "GRID_NAMES = ${GRID_NAMES}" | |||
echo | |||
|
|||
echo `which wgrib2` |
Check warning
Code scanning / shellcheck
Quote this to prevent word splitting. Warning
@@ -20,6 +20,7 @@ | |||
echo "GRID_NAMES = ${GRID_NAMES}" | |||
echo | |||
|
|||
echo `which wgrib2` |
Check notice
Code scanning / shellcheck
Useless echo? Instead of 'echo $(cmd)', just use 'cmd'. Note
@@ -20,6 +20,7 @@ | |||
echo "GRID_NAMES = ${GRID_NAMES}" | |||
echo | |||
|
|||
echo `which wgrib2` |
Check notice
Code scanning / shellcheck
Use $(...) notation instead of legacy backticks .... Note
@@ -20,6 +20,7 @@ | |||
echo "GRID_NAMES = ${GRID_NAMES}" | |||
echo | |||
|
|||
echo `which wgrib2` |
Check notice
Code scanning / shellcheck
'which' is non-standard. Use builtin 'command -v' instead. Note
@@ -20,6 +20,7 @@ | |||
echo "GRID_NAMES = ${GRID_NAMES}" | |||
echo | |||
|
|||
echo `which wgrib2` |
Check notice
Code scanning / shellcheck
Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). Note
Description
Temporary fix for Rocky8
Type of change
Fixed modules for Rocky8
Change characteristics
How has this been tested?
Tested MYNN forecast (120hrs) on Hera.
Checklist