Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for Rocky8 (rt) #57

Merged
merged 3 commits into from
May 17, 2024

Conversation

kayeekayee
Copy link
Collaborator

Description

Temporary fix for Rocky8

Type of change

Fixed modules for Rocky8

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Tested MYNN forecast (120hrs) on Hera.

Checklist

  • [ x] Any dependent changes have been merged and published
  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] My changes generate no new warnings
  • [ x] New and existing tests pass with my changes
  • [ x] I have made corresponding changes to the documentation if necessary

@@ -20,6 +20,7 @@
echo "GRID_NAMES = ${GRID_NAMES}"
echo

echo `which wgrib2`

Check warning

Code scanning / shellcheck

Quote this to prevent word splitting. Warning

Quote this to prevent word splitting.
@@ -20,6 +20,7 @@
echo "GRID_NAMES = ${GRID_NAMES}"
echo

echo `which wgrib2`

Check notice

Code scanning / shellcheck

Useless echo? Instead of 'echo $(cmd)', just use 'cmd'. Note

Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
@@ -20,6 +20,7 @@
echo "GRID_NAMES = ${GRID_NAMES}"
echo

echo `which wgrib2`

Check notice

Code scanning / shellcheck

Use $(...) notation instead of legacy backticks .... Note

Use $(...) notation instead of legacy backticks ....
@@ -20,6 +20,7 @@
echo "GRID_NAMES = ${GRID_NAMES}"
echo

echo `which wgrib2`

Check notice

Code scanning / shellcheck

'which' is non-standard. Use builtin 'command -v' instead. Note

'which' is non-standard. Use builtin 'command -v' instead.
@@ -20,6 +20,7 @@
echo "GRID_NAMES = ${GRID_NAMES}"
echo

echo `which wgrib2`

Check notice

Code scanning / shellcheck

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). Note

Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore).
@kayeekayee kayeekayee changed the title Temporary fix for Rocky8 Temporary fix for Rocky8 (rt) May 17, 2024
@jderrico-noaa jderrico-noaa merged commit 5d77948 into NOAA-GSL:gsl_ufs_rt May 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants