Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configurable alert to convey shutdown info #1078

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

ian-noaa
Copy link
Collaborator

Add the ability to display a bootstrap 5 alert to convey shutdown information to users. The alert visibility and message are controlled via the config file.

@ian-noaa
Copy link
Collaborator Author

For reference, the alert will look like so:

image

Copy link
Collaborator

@randytpierce randytpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I was wondering if it might be easier to just let the existence of the alert text trigger the message, i.e. if the text were empty ignore it, but this is fine.

Whether the alert displays is now contingent on whether there's a
message in the config.
@ian-noaa
Copy link
Collaborator Author

Good point, Randy. I've updated the app so it tests if the alert message is set.

@ian-noaa ian-noaa merged commit 35485a7 into development Sep 29, 2023
8 checks passed
@ian-noaa ian-noaa deleted the 1077-add-a-banner-to-the-home-app branch September 29, 2023 18:58
@ian-noaa ian-noaa linked an issue Oct 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a banner to the home app
3 participants