Update container image to address vulnerabilities #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously installing OS-vendored versions of our Python dependencies as that was easiest when on Alpine and dealing with musl. We're now on a Debian-base image so pip packages will be well tested and compatible. I also added g++ and build-essentials to support ARM/Apple Silicon builds.
mollybsmith-noaa
approved these changes
Jul 7, 2023
|
Thanks! It looks like this didn't change the build times appreciably - the longest is still taking ~15 min. |
ian-noaa
deleted the
999-update-container-image-to-address-vulnerabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously installing OS-vendored versions of our Python dependencies as that was easiest when on Alpine and dealing with
musl. We're now on a Debian-base image sopippackages will be well-tested, compatible, and more up-to-date than the OS-vendored ones.I also added
g++andbuild-essentialsto the image to support ARM/Apple Silicon builds.