Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py #92

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Aug 22, 2024

Description
This PR moves the unit test: test_eta.py out of pace/tests/main/grid into NDSL/tests/grid, as NDSL handles hybrid pressure variable initialization. Within pace, one can still run the test if needed after installation of NDSL.

This PR should be merged before PR 65 in NDSL.

How Has This Been Tested?
Tested using the remaining unit tests in pace.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino changed the title Changes to test_eta.py to support changes in PR 65 in NDSL pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py Aug 27, 2024
Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bensonr
bensonr previously approved these changes Sep 6, 2024
@fmalatino fmalatino merged commit 6640a99 into NOAA-GFDL:develop Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants