Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated container for Github Action and reusable workflow - Redo #89

Merged
merged 19 commits into from
Jun 26, 2024

Conversation

mlee03
Copy link
Collaborator

@mlee03 mlee03 commented Jun 26, 2024

Description

The changes did not go in correctly in PR #87 due to faulty merging issues on my part. This PR contains the correct changes to the workflow files:

In this PR, the CI workflow is changed to run in this container. The new image is built from a base miniforge image. GNU compilers, netCDF and HDF5 libraries, and MPICH have been installed. The default python version is set to 3.11.7.

Tests with OpenMPI have been temporarily removed. The tests will be added with updates to the OpenMPI CI image.

In addition, reusable workflow capabilities have been added. Pace CI workflow can now be triggered by submodules.

Fixes # (issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@mlee03 mlee03 requested a review from fmalatino June 26, 2024 14:35
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 777b332 into NOAA-GFDL:develop Jun 26, 2024
2 checks passed
@mlee03 mlee03 deleted the ci_testing_2 branch July 1, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants