Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working baroclinic test case example #81

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

oelbert
Copy link
Contributor

@oelbert oelbert commented Apr 18, 2024

Description
Includes an example of the moist baroclinic instability test case and resolves a couple of final notebook version mismatches

How Has This Been Tested?
The example notebook has been run from scratch with a newly built image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck
Copy link
Collaborator

Great work. We really ought to have those notebooks parts of the ci, they are great woopsies catcher

@fmalatino fmalatino merged commit e535ba6 into NOAA-GFDL:develop Apr 19, 2024
4 checks passed
@mlee03
Copy link
Collaborator

mlee03 commented Apr 19, 2024

Which notebooks should be considered part of CI? I can add them to run in the CI container.

@FlorianDeconinck
Copy link
Collaborator

I'd say all? Unless they take a large amount of time, but since they are example of usage they should all be checked to be working

@mlee03
Copy link
Collaborator

mlee03 commented Apr 19, 2024

Will look into it!

@oelbert
Copy link
Contributor Author

oelbert commented Apr 19, 2024

I think the baroclinic_example, geberate_eta_file, and stencil_definition notebooks are the most important ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants