Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the missing symbol issue in stencils with scalar arguments #26

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

xyuan
Copy link

@xyuan xyuan commented Aug 9, 2024

Description
fix the bugs in the scalar function argument in stencils, this bug caused by the unreachable code trimming due to the non-overlapped loop region. This fix releases the unreachable code trimming and keep the same IR to dace which has the same function signatures as in the function call tree when orchestration option is used.

this fix requires to work with GridTools/gt4py#1612.

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • [ y ] My code follows the style guidelines of this project
  • [ y ] I have performed a self-review of my own code
  • [ y] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ y ] My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

@xyuan xyuan changed the title fix the missing symbol issue in these stencils fix the missing symbol issue in stencils with scalar arguments Aug 9, 2024
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review after PR 1612 in GT4Py

oelbert
oelbert previously approved these changes Aug 12, 2024
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like if you run the linter it should work out, then I think it's good to go

@fmalatino
Copy link
Contributor

I have been able to test these changes, along with the changes in PR 1612 in GT4Py, in a c384 16x16 layout baroclinic configuration.

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmalatino fmalatino merged commit c489bb5 into NOAA-GFDL:develop Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants