Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ttranslate test --which_savepoint #84

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Ttranslate test --which_savepoint #84

merged 2 commits into from
Nov 14, 2024

Conversation

FlorianDeconinck
Copy link
Collaborator

New feature for translate test --which_savepoint=X with X a number, that allows to run only the given savepoint for a test when there's more than 1

Other QOL:

  • better error when output netcdf is missing a required field
  • remove return None on Float which throws mypy/flak8 into a tailspin
  • fix a missing type check for regular python int

@FlorianDeconinck
New option: which_savepoint
1eda108 
Better error on bad output data
Fix missing integer type check
@FlorianDeconinck
QOL for mypy/flak8 type hints
b1b3ac0
@fmalatino fmalatino self-requested a review November 13, 2024 15:09
@FlorianDeconinck FlorianDeconinck merged commit 53b273b into NOAA-GFDL:develop Nov 14, 2024
5 checks passed
@FlorianDeconinck FlorianDeconinck deleted the qol/translate_test_which_savepoint branch November 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalatino fmalatino fmalatino approved these changes

@bensonr bensonr bensonr approved these changes

@oelbert oelbert Awaiting requested review from oelbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorianDeconinck @bensonr @fmalatino