Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiModal metric threshold override #79

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Oct 9, 2024

Description
Add threshold overrides to the multimodal metric using the following yaml schema

ComputeUwshcu:
  - backend: dace:cpu
    multimodal:
      mmr_relative_fraction: 1e-2
      mmr_absolute_eps: 1e-10 
      mmr_ulp_threshold: 10

How Has This Been Tested?
Locally on GEOS physics code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@oelbert
Copy link
Collaborator

oelbert commented Oct 9, 2024

At this point it's probably useful to document the error thresholding and reporting behavior somewhere, like to explain what ulp_threshold means or why some tests use the threshold yamls vs setting self._max_error

Florian Deconinck added 2 commits October 9, 2024 12:29
…reshold_override' into feature/multimodal_metric_threshold_override
@FlorianDeconinck
Copy link
Collaborator Author

At this point it's probably useful to document the error thresholding and reporting behavior somewhere, like to explain what ulp_threshold means or why some tests use the threshold yamls vs setting self._max_error

There's some instruction in pyFV3. Let me unearth those, complete them and moved them here

@FlorianDeconinck
Copy link
Collaborator Author

Ping @oelbert / @fmalatino: this is blocking us

fmalatino
fmalatino previously approved these changes Oct 15, 2024
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fmalatino
fmalatino previously approved these changes Oct 22, 2024
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck FlorianDeconinck merged commit aed5912 into NOAA-GFDL:develop Oct 23, 2024
5 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/multimodal_metric_threshold_override branch October 23, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants