Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate code for fast deploy of NDSL #39

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented May 14, 2024

Description
In order to present an unified, easy and clean API to the user, we start here a series of "boilerplate" code that wrap common use cases. The first of those is the "quick test" with a one tile, no boundaries, no comms, for numpy and orchestrated dace:cpu

How Has This Been Tested?
Adding two boilerplate code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New check tests, if applicable, are included

fmalatino
fmalatino previously approved these changes May 14, 2024
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

xyuan
xyuan previously approved these changes May 15, 2024
Copy link
Collaborator

@xyuan xyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we have a util directory, and put all these utility code there instead of ndsl directory?

@FlorianDeconinck
Copy link
Collaborator Author

I personally don't like util directories as they become a dumping ground for everything and anything quickly (we use to have one we clean up with Frank). Each tools & features should be named with what they do

@xyuan
Copy link
Collaborator

xyuan commented May 15, 2024 via email

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small suggestion if you want for names.

Is part of the thinking that we will end up making a similar function for gpu orchestrated backends and others?

ndsl/boilerplate.py Outdated Show resolved Hide resolved
ndsl/boilerplate.py Outdated Show resolved Hide resolved
@FlorianDeconinck FlorianDeconinck dismissed stale reviews from xyuan and fmalatino via 0f8906b May 20, 2024 13:55
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fmalatino fmalatino merged commit e30bd6b into develop May 20, 2024
3 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/boilerplate branch May 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants