Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested version in dependent repositories and fixing circular imports for release 2024.03.01 #31

Merged
merged 13 commits into from
Mar 18, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Mar 18, 2024

Description
2024.03.00 was not tested across dependent repositories, pyFV3, pySHiELD, and pace. Exposure of CubedToLatLon in ndsl was removed to avoid a circular import.

How Has This Been Tested?
All currently implemented unit and translate tests in the dependent repositories.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 7fdfa51 into main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants