Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for circular imports in pyFV3 #28

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Mar 13, 2024

Description
Changes to the import methods to avoid circular imports

Fixes # (issue)
This is a hotfix to v.2024.03.00

How Has This Been Tested?
Tested via lint and currently implemented translate tests
OS: RHEL 8.9 Ootpa
Built conda environment using workflow in github action configurations

Installed this branch in pace, pyFV3, and pySHiELD to verify that the changes also avoid circular import issues in these modules.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino marked this pull request as ready for review March 13, 2024 16:25
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit e37c58b into develop Mar 13, 2024
6 checks passed
@FlorianDeconinck FlorianDeconinck deleted the fix/circ_import branch March 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants