Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basic_operations.py from pyFV3/stencils to ndsl/stencils #21

Merged
merged 10 commits into from
Apr 1, 2024
Merged

Added basic_operations.py from pyFV3/stencils to ndsl/stencils #21

merged 10 commits into from
Apr 1, 2024

Conversation

fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Mar 6, 2024 •
edited
Loading

Description
Added basic_operations.py from pyFV3/stencils to ndsl/stencils

Fixes # 18

How Has This Been Tested?
Tested via lint and currently implemented translate tests
OS: RHEL 8.9 Ootpa
Built conda environment using workflow in github action configurations

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino mentioned this pull request Mar 6, 2024
Closed
@fmalatino fmalatino changed the title Added basic_operations.py from pyFV3 to ndsl/stencils Added basic_operations.py from pyFV3/stencils to ndsl/stencils Mar 7, 2024
@fmalatino fmalatino marked this pull request as ready for review March 11, 2024 19:05
@fmalatino fmalatino mentioned this pull request Mar 11, 2024
Merged
FlorianDeconinck
FlorianDeconinck requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs unit tests

@fmalatino fmalatino marked this pull request as draft March 11, 2024 20:07
@fmalatino fmalatino marked this pull request as ready for review March 27, 2024 19:26
FlorianDeconinck
FlorianDeconinck requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc all stencils and we should be gone

tests/test_basic_operations.py Outdated Show resolved Hide resolved
tests/test_basic_operations.py Outdated Show resolved Hide resolved
FlorianDeconinck
FlorianDeconinck requested changes Mar 29, 2024
View reviewed changes
tests/test_basic_operations.py Outdated Show resolved Hide resolved
@fmalatino fmalatino linked an issue Mar 29, 2024 that may be closed by this pull request
Move common stencils from pyFV3 to NDSL #18
Closed
FlorianDeconinck
FlorianDeconinck requested changes Mar 29, 2024
View reviewed changes
tests/test_basic_operations.py Outdated

copy(f_in=infield.data, f_out=outfield.data)

assert (infield.data == outfield.data).any()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.all() since we want all of them to match

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, my bad

FlorianDeconinck
FlorianDeconinck approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit 85c2213 into develop Apr 1, 2024
3 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/stencil_basic_ops branch April 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

@oelbert oelbert Awaiting requested review from oelbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move common stencils from pyFV3 to NDSL
2 participants
@fmalatino @FlorianDeconinck