-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: Do not specify a separate service account #2780
Hotfix: Do not specify a separate service account #2780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'm going to add a fix to the CI tests as well to do a shallow submodule checkout. The unit tests are failing due to too much disk space usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@CoryMartin-NOAA @RussTreadon-NOAA @danholdaway It appears that the download error I am seeing here and in the Jenkins checkouts is not due to disk limitation, but limitations placed by git-lfs repositories. The See |
We can set ❯❯❯ git clone emcgh:jcb ✘ 130
Cloning into 'jcb'...
remote: Enumerating objects: 656, done.
remote: Counting objects: 100% (18/18), done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 656 (delta 0), reused 0 (delta 0), pack-reused 638
Receiving objects: 100% (656/656), 120.28 KiB | 8.59 MiB/s, done.
Resolving deltas: 100% (286/286), done.
Downloading etc/jcb-text.png (11 KB)
Error downloading object: etc/jcb-text.png (fdb18dd): Smudge error: Error downloading etc/jcb-text.png (fdb18ddd36bb2285c6e588ad94559babc318eba3e802b9e1c349fed18a3a82af): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.
Errors logged to '/Users/rmahajan/scratch/jcb/.git/lfs/logs/20240719T142102.976203.log'.
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: etc/jcb-text.png: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/' After setting ❯❯❯ git clone emcgh:jcb
Cloning into 'jcb'...
remote: Enumerating objects: 656, done.
remote: Counting objects: 100% (18/18), done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 656 (delta 0), reused 0 (delta 0), pack-reused 638
Receiving objects: 100% (656/656), 120.28 KiB | 8.59 MiB/s, done.
Resolving deltas: 100% (286/286), done.
Identity set to Rahul Mahajan <[email protected]> |
Unfortunately, #2775 CI failed to find the |
ci/scripts/clone-build_ci.sh
Outdated
@@ -44,6 +44,7 @@ if [[ -d global-workflow ]]; then | |||
rm -Rf global-workflow | |||
fi | |||
|
|||
export GIT_LFS_SKIP_SMUDGE=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not need this after the hotfix, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I'll revert this change here, in my local Jenkins clones, and in #2775 and restart CI in the latter.
…ount * origin/develop: Hotfix: Update jcb to avoid git-lfs files (NOAA-EMC#2782)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closing, merged into #2775. |
Description
Separate service accounts are not required on any system and causes issues when running CI. This removes service accounts from the workflow setup scripts.
Type of change
Change characteristics
How has this been tested?
Ran setup scripts on Hera with
ACCOUNT=nems
; verifiedaccount
was set tonems
in the resulting rocoto XML for all jobs.Checklist