Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task to process reforecast variables to save on WCOSS2 #2680
Add task to process reforecast variables to save on WCOSS2 #2680
Changes from 112 commits
ec4b800
2923780
7ff9a28
25cf481
8845dc7
f46544e
e9702c8
e378727
4fbc7ac
ff36ef2
c173979
43b0ac1
0deabb0
177783b
7235fc1
d3688ed
f807374
215a726
b79237c
e3f61ba
c9e49d7
b1076f3
e7adce9
e1f2e71
a310f0e
1917d26
b88bae4
f2a9e33
5b964ef
1049801
1168566
c2a23b7
1a91e4a
9417dd6
99d3adf
f3df65e
e0f8d32
64beacc
2a5aab9
01b601a
3a8e90f
1ca415e
7a8a40f
a84e0d9
ecb069c
e280a36
c79a8b6
b5893db
03ba201
2a6071a
cdc4d89
456dbdf
e496529
c7b7c4d
8ab7ec3
7ddb470
c44a5bc
b61d98f
4e4715f
fca3c47
94ebfbb
5774c2a
9c73505
3947d18
dd6b1b1
f828121
ecf788f
1beb044
987f27f
156306f
674c40f
2be9a15
235886b
c2db0a5
a140ef6
c7f8364
32c25a6
d349d66
8ef0bd9
5310eaa
1d570ea
491be9c
d9a1681
a0343a3
ac855af
f768627
f35452f
de3e5e6
ef7799b
2f89276
beb9e5e
55f65d5
98c3c48
1985224
8610220
4f5db1e
701a85c
16bff05
3a920be
d3e8c34
1022872
22de8a8
88e4ccf
44eb052
bffb227
39e5582
9a03c58
ec7a307
bee6fa4
e565ff0
9373721
90c692f
220fce1
c968e1f
d86b1e9
1f77718
89f5621
2e4ca68
f8d24f2
0bfc12f
519922c
9d3ba90
e64a640
f8bd19d
db4b432
cd1c5d6
16b546d
0384906
7b523eb
d14c291
a7433a3
68f2714
655175f
a2abff7
148d8db
ea0bd8c
142450a
380dfee
b293a65
43a0b10
7bd4b67
c7e5d08
16425cb
bdb429c
1add8e1
bf19e74
c869271
f7357ea
f572f6b
85e18ed
1f40284
6d9ccb2
97c2f8f
5aa68a7
9a724f4
bffeb25
68b3e24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WalterKolczynski-NOAA The goal is to save the final products on WCOSS2. The output for this task is currently being saved to
COM_BASE
, which is a temporary directory. Should this be changed to a variable that defines a noscrub directory on WCOSS2, or can the output be copied fromCOM_BASE
to a noscrub directory in the archive job?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably use
ARCDIR
, which is what the GFS uses. I wouldn't call theseCOM
, I'd call them something else to avoid confusion (and they can be moved toconfig.extractvars
as nothing else uses them).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @WalterKolczynski-NOAA. I am removing these from
config.com
since these are not needed by any other job downstream. The archive job will not need this because these extracted model fields will not be needed on HPSS. I will also remove these fromJGLOBAL_EXTRACTVARS
. I will define anARCDIR
variable inconfig.extractvars
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need pass-throughs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was suggested by @DavidHuber-NOAA in his review (#2680 (comment)). If @DavidHuber-NOAA has no objections, I can replace the job-specific variable
FHMAX_HF_EV
withFHMAX_HF_GFS
.