Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage variational and ensemble DA job files with Jinja2-templated YAMLs #2654

Closed
Closed
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
3a8f527
Initial commit
DavidNew-NOAA May 31, 2024
6904982
Update atm_berror_bump_fix.yaml.j2
DavidNew-NOAA Jun 3, 2024
0b37fe5
Update atm_berror_gsibec_fix.yaml.j2
DavidNew-NOAA Jun 3, 2024
d770b63
Update atm_berror_identity_fix.yaml.j2
DavidNew-NOAA Jun 3, 2024
0187bba
Update atm_bkg_fix.yaml.j2
DavidNew-NOAA Jun 3, 2024
4dcd47a
Rename some things
DavidNew-NOAA Jun 3, 2024
e61963d
Merge branch 'feature/stage_from_yaml' of https://github.com/DavidNew…
DavidNew-NOAA Jun 3, 2024
f91297d
Rename some things
DavidNew-NOAA Jun 3, 2024
983d720
Add changes to analysis python scripts
DavidNew-NOAA Jun 3, 2024
6e44a5f
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 4, 2024
2490049
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 4, 2024
3022393
Minor fix
DavidNew-NOAA Jun 4, 2024
cc1a3b6
Minor update
DavidNew-NOAA Jun 4, 2024
2097116
Minor update
DavidNew-NOAA Jun 4, 2024
5327711
Coding norms
DavidNew-NOAA Jun 4, 2024
4d36caf
Move some stuff around
DavidNew-NOAA Jun 4, 2024
ba2d12d
Add time loop for some staging
DavidNew-NOAA Jun 5, 2024
2138df1
Merge branch 'NOAA-EMC:develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 6, 2024
f70b0ad
Remove all references to mytask.config and mytask.runtime_config
DavidNew-NOAA Jun 7, 2024
3f8ba42
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 7, 2024
49f8593
Update wxflow hash
DavidNew-NOAA Jun 7, 2024
b6213a5
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 11, 2024
2bd9949
Tab out Jinja2 templates for readability
DavidNew-NOAA Jun 11, 2024
458aa34
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 12, 2024
2cb6664
Use replace_tmpl filter
DavidNew-NOAA Jun 13, 2024
bd7f770
Update wxflow hash
DavidNew-NOAA Jun 13, 2024
f8a18be
Update wxflow hash and fix big in lgetkf staging file
DavidNew-NOAA Jun 14, 2024
4b21d8a
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 17, 2024
c6223c4
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 17, 2024
18c596c
Merge branch 'feature/stage_from_yaml' of https://github.com/DavidNew…
DavidNew-NOAA Jun 17, 2024
2c8feb5
Simplify Jinja2 templates a bit
DavidNew-NOAA Jun 17, 2024
2c5ef59
Replace CDUMP with RUN
DavidNew-NOAA Jun 17, 2024
dcfc40f
Fix bug
DavidNew-NOAA Jun 17, 2024
9d1c2ec
Merge branch 'develop' into feature/stage_from_yaml
DavidNew-NOAA Jun 20, 2024
ddcd376
Updates
DavidNew-NOAA Jun 20, 2024
7aa041e
Refactor aero_prepobs.py like other tasks
DavidNew-NOAA Jun 20, 2024
e175b25
Update wxflow hash
DavidNew-NOAA Jun 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions parm/config/gfs/config.atmanl
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@

export CRTM_FIX_YAML="${PARMgfs}/gdas/atm_crtm_coeff.yaml.j2"
export JEDI_FIX_YAML="${PARMgfs}/gdas/atm_jedi_fix.yaml.j2"
export VAR_BKG_STAGING_YAML="${PARMgfs}/gdas/atm_var_bkg_staging.yaml.j2"
export BERROR_STAGING_YAML="${PARMgfs}/gdas/atm_berror_"${STATICB_TYPE}"_staging.yaml.j2"
Fixed Show fixed Hide fixed
export FV3ENS_STAGING_YAML="${PARMgfs}/gdas/atm_var_fv3ens_staging.yaml.j2"

export layout_x_atmanl=@LAYOUT_X_ATMANL@
export layout_y_atmanl=@LAYOUT_Y_ATMANL@
Expand Down
1 change: 1 addition & 0 deletions parm/config/gfs/config.atmensanl
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export INTERP_METHOD='barycentric'

export CRTM_FIX_YAML="${PARMgfs}/gdas/atm_crtm_coeff.yaml.j2"
export JEDI_FIX_YAML="${PARMgfs}/gdas/atm_jedi_fix.yaml.j2"
export LGETKF_BKG_STAGING_YAML="${PARMgfs}/gdas/atm_lgetkf_bkg_staging.yaml.j2"

export layout_x_atmensanl=@LAYOUT_X_ATMENSANL@
export layout_y_atmensanl=@LAYOUT_Y_ATMENSANL@
Expand Down
23 changes: 23 additions & 0 deletions parm/gdas/atm_berror_bump_staging.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{% set src_dir = BERROR_DATA_DIR %}
{% set dest_dir = DATA ~ '/berror' %}
{% set ftype_list = ['cor_rh', 'cor_rv', 'stddev'] %}
{% set nprocs = ntiles * layout_x * layout_y %}

mkdir:
- '{{ dest_dir }}'

copy:
{% for ftype in ftype_list %}
{% set prefix = BERROR_DATE | to_fv3time ~ '.' ~ ftype %}
{% set fname = prefix ~ '.coupler.res' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% for itile in range(1,7) %}
{% set fname = prefix ~ '.fv_tracer.res.tile' ~ itile ~ '.nc' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% endfor %}
{% endfor %}

{% for nn in range(1,nprocs+1) %}
{% set fname = 'nicas_aero_nicas_local_%06d-%06d.nc' | format(nprocs, nn) %}
DavidNew-NOAA marked this conversation as resolved.
Show resolved Hide resolved
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% endfor %}
10 changes: 10 additions & 0 deletions parm/gdas/atm_berror_gsibec_staging.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{% set src_dir = HOMEgfs ~ '/fix/gdas/gsibec/' ~ CASE_ANL %}
{% set dest_dir = DATA ~ '/berror' %}
{% set fname_list = ['gfs_gsi_global.nml', 'gsi-coeffs-gfs-global.nc4'] %}

mkdir:
- '{{ dest_dir }}'
copy:
{% for fname in fname_list %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% endfor %}
27 changes: 27 additions & 0 deletions parm/gdas/atm_lgetkf_bkg_staging.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{% set ftype_list = ['fv_core.res', 'fv_srf_wnd.res', 'fv_tracer.res', 'phy_data', 'sfc_data'] %}
{% set prefix = current_cycle | to_fv3time %}
DavidNew-NOAA marked this conversation as resolved.
Show resolved Hide resolved

mkdir:
{% for imem in range(1,NMEM_ENS+1) %}
{% set memchar = 'mem%03d' | format(imem) %}
- '{{ DATA }}/bkg/{{ memchar }}'
- '{{ DATA }}/anl/{{ memchar }}'
{% endfor %}
copy:
{% for imem in range(1,NMEM_ENS+1) %}
{% set memchar = 'mem%03d' | format(imem) %}
{% set src_dir = COM_ATMOS_RESTART_TMPL | replace('${ROTDIR}', ROTDIR)
| replace('${RUN}', 'enkfgdas')
| replace('${YMD}', previous_cycle | to_YMD)
| replace('${HH}', previous_cycle | strftime('%H'))
| replace('${MEMDIR}', memchar) %}
{% set dest_dir = DATA ~ '/bkg/' ~ memchar %}
{% set fname = prefix ~ '.coupler.res' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% for ftype in ftype_list %}
{% for itile in range(1,7) %}
{% set fname = prefix ~ '.' ~ ftype ~ '.tile' ~ itile ~ '.nc' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% endfor %}
{% endfor %}
{% endfor %}
16 changes: 16 additions & 0 deletions parm/gdas/atm_var_bkg_staging.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{% set src_dir = COM_ATMOS_RESTART_PREV %}
{% set dest_dir = DATA ~ '/bkg' %}
{% set ftype_list = ['fv_core.res', 'fv_srf_wnd.res', 'fv_tracer.res', 'phy_data', 'sfc_data'] %}
DavidNew-NOAA marked this conversation as resolved.
Show resolved Hide resolved
{% set prefix = current_cycle | to_fv3time %}
DavidNew-NOAA marked this conversation as resolved.
Show resolved Hide resolved

mkdir:
- '{{ dest_dir }}'
copy:
{% set fname = prefix ~ '.coupler.res' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% for ftype in ftype_list %}
{% for itile in range(1,7) %}
{% set fname = prefix ~ '.' ~ ftype ~ '.tile' ~ itile ~ '.nc' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% endfor %}
{% endfor %}
27 changes: 27 additions & 0 deletions parm/gdas/atm_var_fv3ens_staging.yaml.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{% set ftype_list = ['fv_core.res', 'fv_srf_wnd.res', 'fv_tracer.res', 'phy_data', 'sfc_data'] %}
{% set prefix = current_cycle | to_fv3time %}
DavidNew-NOAA marked this conversation as resolved.
Show resolved Hide resolved

mkdir:
{% for imem in range(1,NMEM_ENS+1) %}
{% set memchar = 'mem%03d' | format(imem) %}
{% set dest_dir = DATA ~ '/ens/' ~ memchar %}
- '{{ dest_dir }}'
{% endfor %}
copy:
{% for imem in range(1,NMEM_ENS+1) %}
{% set memchar = 'mem%03d' | format(imem) %}
{% set src_dir = COM_ATMOS_RESTART_TMPL | replace('${ROTDIR}', ROTDIR)
| replace('${RUN}', 'enkfgdas')
| replace('${YMD}', previous_cycle | to_YMD)
| replace('${HH}', previous_cycle | strftime('%H'))
| replace('${MEMDIR}', memchar) %}
{% set dest_dir = DATA ~ '/ens/' ~ memchar %}
{% set fname = prefix ~ '.coupler.res' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% for ftype in ftype_list %}
{% for itile in range(1,7) %}
{% set fname = prefix ~ '.' ~ ftype ~ '.tile' ~ itile ~ '.nc' %}
- ['{{ src_dir }}/{{ fname }}', '{{ dest_dir }}/{{ fname }}']
{% endfor %}
{% endfor %}
{% endfor %}
100 changes: 0 additions & 100 deletions ush/python/pygfs/task/analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,44 +194,6 @@ def add_fv3_increments(self, inc_file_tmpl: str, bkg_file_tmpl: str, incvars: Li
except (AttributeError, RuntimeError):
pass # checksum is missing, move on

@logit(logger)
def get_bkg_dict(self, task_config: Dict[str, Any]) -> Dict[str, List[str]]:
"""Compile a dictionary of model background files to copy

This method is a placeholder for now... will be possibly made generic at a later date

Parameters
----------
task_config: Dict
a dictionary containing all of the configuration needed for the task

Returns
----------
bkg_dict: Dict
a dictionary containing the list of model background files to copy for FileHandler
"""
bkg_dict = {'foo': 'bar'}
return bkg_dict

@logit(logger)
def get_berror_dict(self, config: Dict[str, Any]) -> Dict[str, List[str]]:
"""Compile a dictionary of background error files to copy

This method is a placeholder for now... will be possibly made generic at a later date

Parameters
----------
config: Dict
a dictionary containing all of the configuration needed

Returns
----------
berror_dict: Dict
a dictionary containing the list of background error files to copy for FileHandler
"""
berror_dict = {'foo': 'bar'}
return berror_dict

@logit(logger)
def link_jediexe(self) -> None:
"""Compile a dictionary of background error files to copy
Expand All @@ -258,68 +220,6 @@ def link_jediexe(self) -> None:

return exe_dest

@staticmethod
@logit(logger)
def get_fv3ens_dict(config: Dict[str, Any]) -> Dict[str, Any]:
"""Compile a dictionary of ensemble member restarts to copy

This method constructs a dictionary of ensemble FV3 restart files (coupler, core, tracer)
that are needed for global atmens DA and returns said dictionary for use by the FileHandler class.

Parameters
----------
config: Dict
a dictionary containing all of the configuration needed

Returns
----------
ens_dict: Dict
a dictionary containing the list of ensemble member restart files to copy for FileHandler
"""
# NOTE for now this is FV3 restart files and just assumed to be fh006

# define template
template_res = config.COM_ATMOS_RESTART_TMPL
prev_cycle = config.previous_cycle
tmpl_res_dict = {
'ROTDIR': config.ROTDIR,
'RUN': config.RUN,
'YMD': to_YMD(prev_cycle),
'HH': prev_cycle.strftime('%H'),
'MEMDIR': None
}

# construct ensemble member file list
dirlist = []
enslist = []
for imem in range(1, config.NMEM_ENS + 1):
memchar = f"mem{imem:03d}"

# create directory path for ensemble member restart
dirlist.append(os.path.join(config.DATA, config.dirname, f'mem{imem:03d}'))

# get FV3 restart files, this will be a lot simpler when using history files
tmpl_res_dict['MEMDIR'] = memchar
rst_dir = Template.substitute_structure(template_res, TemplateConstants.DOLLAR_CURLY_BRACE, tmpl_res_dict.get)
run_dir = os.path.join(config.DATA, config.dirname, memchar)

# atmens DA needs coupler
basename = f'{to_fv3time(config.current_cycle)}.coupler.res'
enslist.append([os.path.join(rst_dir, basename), os.path.join(config.DATA, config.dirname, memchar, basename)])

# atmens DA needs core, srf_wnd, tracer, phy_data, sfc_data
for ftype in ['fv_core.res', 'fv_srf_wnd.res', 'fv_tracer.res', 'phy_data', 'sfc_data']:
template = f'{to_fv3time(config.current_cycle)}.{ftype}.tile{{tilenum}}.nc'
for itile in range(1, config.ntiles + 1):
basename = template.format(tilenum=itile)
enslist.append([os.path.join(rst_dir, basename), os.path.join(run_dir, basename)])

ens_dict = {
'mkdir': dirlist,
'copy': enslist,
}
return ens_dict

@staticmethod
@logit(logger)
def tgz_diags(statfile: str, diagdir: str) -> None:
Expand Down
Loading
Loading