Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First installment for running w/ replay. #2638

Closed
wants to merge 12 commits into from

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented May 29, 2024

Description

This PR:

A flag REPLAY_ICS should be set to YES in config.base or config.fcst if want to use replay ICS
Running with replay requires perturbation files pretending to be increments as that is the mechanism for generating ensemble ics from deterministic restarts.

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Ran forecast jobs on Hera for forecast-only

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@aerorahul aerorahul marked this pull request as ready for review May 31, 2024 20:39
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_postdet.sh Outdated Show resolved Hide resolved
ush/forecast_predet.sh Outdated Show resolved Hide resolved
ush/forecast_predet.sh Outdated Show resolved Hide resolved
ush/forecast_predet.sh Outdated Show resolved Hide resolved
ush/forecast_predet.sh Outdated Show resolved Hide resolved
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
@aerorahul
Copy link
Contributor Author

@NeilBarton-NOAA I should perhaps open this PR against your replay PR.

@NeilBarton-NOAA
Copy link
Contributor

@aerorahul that makes more sense in my opinion.

@aerorahul
Copy link
Contributor Author

@aerorahul that makes more sense in my opinion.

@aerorahul that makes more sense in my opinion.
Thanks @NeilBarton-NOAA
I opened one against the branch in your PR
NeilBarton-NOAA#3

@aerorahul aerorahul closed this Jun 4, 2024
@aerorahul aerorahul deleted the feature/replay-1 branch October 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants