Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit Tests for CI Codes #2581

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented May 8, 2024

Description

This PR has the fix for STALLED cases reviled from PR 2700
and also adds Python Unit Testing for testing this along with other CI utility codes into GitHub Actions:

  • Installed Rocoto and wxfow in GitHub Runner for testing key CI utility codes
    • Cashed the install of Rocoto in the GitHub Runners to greatly reduce stetup time for running the unit tests
  • Two Unit Tests Python scripts added
    • test_rocostat.py: rocoto_statcount() rocoto_summary() rocoto_stalled()
    • test_setup.py: setup_expt() test_setup_xml()
  • Reporting mechanism in the Actions tab for Python Unit Testing results
  • Distinct test data directories for specific test cases
    • Test case data for STALLED and RUNNING stored on S3 and pulled using wget during runtime of tests

Type of change

  • Maintenance (code refactor, clean-up, Unit Testing Framework)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issue related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants