Adds GDAS GEMPAK jobs to rocoto task mesh #2126

HenryRWinterbottom · 2023-12-05T21:09:45Z

Description

This PR addresses issue #1219. Rocoto task jobs/rocoto/gempak.sh was updated to support JGDAS_ATMOS_GEMPAK. Rocoto task jobs/rocoto/gempakmeta.sh was added to support JGFS_ATMOS_GEMPAK_META and JGDAS_ATMOS_GEMPAK_META_NCDC.

Resolves #1219
References #1222 #2073

NOTE This is a replicated PR open to resolve developer mishap with Github interface.

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

The Rocoto XML configuration has been executed as follows.

user@host$: cd /scratch1/NCEPDEV/da/Henry.Winterbottom/trunk/global-workflow.develop.20231117/workflow
user@host$: ./setup_xml.py /scratch1/NCEPDEV/da/Henry.Winterbottom/work/GLOBAL_WORKFLOW/x002_gfsv17_issue_1219/x002_gfsv17_issue_1219.xml

The resulting Rocoto workflow is as follows.

       CYCLE                    TASK                       JOBID               STATE         EXIT STATUS     TRIES      DURATION
================================================================================================================================
202103231200             gfsstage_ic                    51952235              QUEUED                   -         0           0.0
202103231200                 gfsfcst                           -                   -                   -         -             -
202103231200            gfspost_f000                    51952236              QUEUED                   -         0           0.0
202103231200            gfspost_f006                    51952237              QUEUED                   -         0           0.0
202103231200            gfspost_f012                    51952238              QUEUED                   -         0           0.0
202103231200                 gfsvrfy                           -                   -                   -         -             -
202103231200             gfsmetpg2g1                           -                   -                   -         -             -
202103231200             gfsmetpg2o1                           -                   -                   -         -             -
202103231200             gfsmetppcp1                           -                   -                   -         -             -
202103231200               gfsgempak                           -                   -                   -         -             -
202103231200           gfsgempakmeta                           -                   -                   -         -             -
202103231200       gfsgempakmetancdc                           -                   -                   -         -             -
202103231200    gfsgempakncdcupapgif                           -                   -                   -         -             -
202103231200      gfsgempakpgrb2spec                           -                   -                   -         -             -
202103231200                 gfsarch                           -                   -                   -         -             -
202103231200              gfscleanup                           -                   -                   -         -             -

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

HenryRWinterbottom · 2023-12-05T21:14:09Z

@KateFriedman-NOAA @WalterKolczynski-NOAA @aerorahul

First of all I apologize for requiring multiple PR for this issue. I will try not to make the same errors in the future which have necessitated this.

Secondly, I worked through all of the comments and suggestions from the previous PR attempt (see #2103). If I missed something, please let me know such that I can resolved ASAP.

I appreciate your patience.

WalterKolczynski-NOAA · 2023-12-05T21:20:37Z

workflow/applications/gfs_forecast_only.py

+        if self.do_bufrsnd:
+            tasks += ['postsnd']
+
+        if self.do_gempak:
+            tasks += ['gempak']
+            tasks += ['gempakmeta']
+            tasks += ['gempakncdcupapgif']
+            tasks += ['gempakpgrb2spec']
+
+        if self.do_awips:
+            tasks += ['awips_20km_1p0deg']
+            tasks += ['awips_g2']
+            tasks += ['fbwinds']
+
+        if self.do_wafs:
+            tasks += ['wafs', 'wafsgcip', 'wafsgrib2', 'wafsgrib20p25', 'wafsblending', 'wafsblending0p25']


This was moved earlier in the script in #2110 (except WAFS, which was deleted). Please make any changes in the new section and remove this.

WalterKolczynski-NOAA · 2023-12-05T21:23:31Z

workflow/applications/gfs_cycled.py

-        if self.do_npoess:
-            configs += ['npoess']


Why is this being removed?

See #2103 (comment)

Fine doing away with the switch, but you still have to add the config file where the other gempak config is being loaded.

workflow/applications/gfs_cycled.py

WalterKolczynski-NOAA · 2023-12-05T21:30:08Z

workflow/applications/applications.py

@@ -61,7 +61,6 @@ def __init__(self, conf: Configuration) -> None:
        self.do_genesis = _base.get('DO_GENESIS', True)
        self.do_genesis_fsu = _base.get('DO_GENESIS_FSU', False)
        self.do_metp = _base.get('DO_METP', False)
-        self.do_npoess = _base.get('DO_NPOESS', False)


Same, why is this being removed?

See #2103 (comment)

henrywinterbottom-wxdev and others added 10 commits December 5, 2023 12:50

Added GEMPAK applications.

09c37ad

Updated valid tasks.

bcc8049

Updated GFS and GDAS tasks.

2955fa1

Updated Rocoto jobs.

c523a4e

Updated applications and tasks.

ae1fbea

Updated NPOESS tasks as requested by the reviewer.

0ed2137

Updated dependency.

fec8ce1

Added NPOESS to GEMPAK as requested by reviewer.

3958215

Grouped related tasks.

196e735

Merge branch 'develop' into feature/gfsv17_issue_1219.fix

9229ef7

HenryRWinterbottom requested review from aerorahul and KateFriedman-NOAA December 5, 2023 21:14

HenryRWinterbottom self-assigned this Dec 5, 2023

HenryRWinterbottom requested a review from WalterKolczynski-NOAA December 5, 2023 21:14

HenryRWinterbottom added the feature New feature or request label Dec 5, 2023

WalterKolczynski-NOAA requested changes Dec 5, 2023

View reviewed changes

HenryRWinterbottom closed this Dec 6, 2023

HenryRWinterbottom deleted the feature/gfsv17_issue_1219.fix branch December 7, 2023 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds GDAS GEMPAK jobs to rocoto task mesh #2126

Adds GDAS GEMPAK jobs to rocoto task mesh #2126

HenryRWinterbottom commented Dec 5, 2023

HenryRWinterbottom commented Dec 5, 2023

WalterKolczynski-NOAA Dec 5, 2023

WalterKolczynski-NOAA Dec 5, 2023

HenryRWinterbottom Dec 5, 2023

WalterKolczynski-NOAA Dec 5, 2023

WalterKolczynski-NOAA Dec 5, 2023

HenryRWinterbottom Dec 5, 2023

Adds GDAS GEMPAK jobs to rocoto task mesh #2126

Adds GDAS GEMPAK jobs to rocoto task mesh #2126

Conversation

HenryRWinterbottom commented Dec 5, 2023

Description

Type of change

Change characteristics

Checklist

HenryRWinterbottom commented Dec 5, 2023

WalterKolczynski-NOAA Dec 5, 2023

Choose a reason for hiding this comment

WalterKolczynski-NOAA Dec 5, 2023

Choose a reason for hiding this comment

HenryRWinterbottom Dec 5, 2023

Choose a reason for hiding this comment

WalterKolczynski-NOAA Dec 5, 2023

Choose a reason for hiding this comment

WalterKolczynski-NOAA Dec 5, 2023

Choose a reason for hiding this comment

HenryRWinterbottom Dec 5, 2023

Choose a reason for hiding this comment