Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AO WCDA test #1963

Merged
merged 45 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
8608302
add a soca test
aerorahul Oct 13, 2023
eced3f4
replace HOMEgfs_PR with HOMEgfs, and HOMEgfs with ROOT_DIR. ROOT_DIR …
aerorahul Oct 13, 2023
a80b61b
update type to system
aerorahul Oct 13, 2023
0715d14
move create_experiment.py to workflow/
aerorahul Oct 13, 2023
e64ae94
fix pycodestyle error
aerorahul Oct 13, 2023
22ae19b
disable the soca test
aerorahul Oct 13, 2023
d008d5b
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Oct 23, 2023
15e3c49
restore from develop
aerorahul Oct 23, 2023
63ea601
update soca test
aerorahul Oct 23, 2023
dc19b59
enable soca PR for testing
aerorahul Oct 23, 2023
8071633
change SLURM_ACCOUNT to j2 template
aerorahul Oct 23, 2023
0a6d721
enable -u to checkout GDASapp in CI
aerorahul Oct 23, 2023
744c5a9
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Oct 31, 2023
58751fa
add exclude for skipping ci for SOCA on orion and wcoss2
aerorahul Oct 31, 2023
87a8039
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Jan 8, 2024
fdd6768
update docs.yaml;
aerorahul Jan 8, 2024
f28199d
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Jan 8, 2024
6cd0d7b
revert docs.yaml to develop
aerorahul Jan 8, 2024
587eb89
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Jan 18, 2024
145bf23
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Jan 24, 2024
e2660d8
revert disabled cases
aerorahul Jan 24, 2024
8dfa55b
remove gefs S2SA disabled test
aerorahul Jan 24, 2024
e81dcbe
bring changes from GV at /scratch1/NCEPDEV/stmp2/Guillaume.Vernieres/…
aerorahul Jan 24, 2024
d8b1ece
rename test case yaml
aerorahul Jan 25, 2024
64c5529
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Jan 25, 2024
28f1ebf
soca related updates
guillaumevernieres Jan 25, 2024
99305c2
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Jan 26, 2024
98d9669
update to develop ci/ structure
aerorahul Jan 26, 2024
5d9fc7e
stage atmosphere increments if doing a warm start and if they are ava…
aerorahul Jan 26, 2024
0cc965d
use ICS from config.file
aerorahul Jan 26, 2024
21c9a0a
minor goofs and turn soca test off till gdasapp updates are in
aerorahul Jan 26, 2024
d103db0
Merge branch 'develop' into feature/soca-updates
guillaumevernieres Jan 26, 2024
3749aae
Merge branch 'develop' into feature/soca-updates
guillaumevernieres Feb 1, 2024
c63f0de
Merge pull request #5 from guillaumevernieres/feature/soca-updates
aerorahul Feb 1, 2024
e27622e
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Feb 2, 2024
b34ed65
remove duplicate atminc.nc found by gv
aerorahul Feb 2, 2024
fdc16c1
increase memory of prepoceanobs
aerorahul Feb 2, 2024
4e995e1
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Feb 5, 2024
b592796
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Feb 5, 2024
af46047
enable soca DA
aerorahul Feb 5, 2024
80c077b
Merge branch 'develop' into feature/soca-test-enabled
aerorahul Feb 7, 2024
58ef58d
make ocnanalvrfy task optional;
aerorahul Feb 7, 2024
d6ea306
fix pycodestyle error
aerorahul Feb 7, 2024
925c20c
update address to obs for SOCA on Hera
aerorahul Feb 8, 2024
333e164
skip AOWCDA test on orion and hercules, for now
aerorahul Feb 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ci/cases/pr/C48mx500_3DVarAOWCDA.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
experiment:
system: gfs
mode: cycled

arguments:
pslot: {{ 'pslot' | getenv }}
app: S2S
resdetatmos: 48
resdetocean: 5.0
comroot: {{ 'RUNTESTS' | getenv }}/COMROOT
expdir: {{ 'RUNTESTS' | getenv }}/EXPDIR
icsdir: {{ 'ICSDIR_ROOT' | getenv }}/C48mx500
idate: 2021032412
edate: 2021032418
nens: 0
gfs_cyc: 0
start: warm
yaml: {{ HOMEgfs }}/ci/cases/yamls/soca_gfs_defaults_ci.yaml

skip_ci_on_hosts:
- orion
- hercules
5 changes: 5 additions & 0 deletions ci/cases/yamls/soca_gfs_defaults_ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
defaults:
!INC {{ HOMEgfs }}/parm/config/gfs/yaml/defaults.yaml
base:
ACCOUNT: {{ 'SLURM_ACCOUNT' | getenv }}
DO_JEDIOCNVAR: "YES"
18 changes: 3 additions & 15 deletions env/HERA.env
Original file line number Diff line number Diff line change
Expand Up @@ -93,31 +93,19 @@ elif [[ "${step}" = "ocnanalbmat" ]]; then

export APRUNCFP="${launcher} -n \$ncmd --multi-prog"

nth_max=$((npe_node_max / npe_node_ocnanalbmat))

export NTHREADS_OCNANAL=${nth_ocnanalbmat:-${nth_max}}
[[ ${NTHREADS_OCNANAL} -gt ${nth_max} ]] && export NTHREADS_OCNANAL=${nth_max}
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalbmat} --cpus-per-task=${NTHREADS_OCNANAL}"
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalbmat}"

elif [[ "${step}" = "ocnanalrun" ]]; then

export APRUNCFP="${launcher} -n \$ncmd --multi-prog"

nth_max=$((npe_node_max / npe_node_ocnanalrun))

export NTHREADS_OCNANAL=${nth_ocnanalrun:-${nth_max}}
[[ ${NTHREADS_OCNANAL} -gt ${nth_max} ]] && export NTHREADS_OCNANAL=${nth_max}
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalrun} --cpus-per-task=${NTHREADS_OCNANAL}"
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalrun}"

elif [[ "${step}" = "ocnanalchkpt" ]]; then

export APRUNCFP="${launcher} -n \$ncmd --multi-prog"

nth_max=$((npe_node_max / npe_node_ocnanalchkpt))

export NTHREADS_OCNANAL=${nth_ocnanalchkpt:-${nth_max}}
[[ ${NTHREADS_OCNANAL} -gt ${nth_max} ]] && export NTHREADS_OCNANAL=${nth_max}
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalchkpt} --cpus-per-task=${NTHREADS_OCNANAL}"
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalchkpt}"

elif [[ "${step}" = "anal" ]] || [[ "${step}" = "analcalc" ]]; then

Expand Down
4 changes: 2 additions & 2 deletions jobs/JGLOBAL_PREP_OCEAN_OBS
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ YMD=${PDY} HH=${cyc} generate_com -rx COMOUT_OBS:COM_OBS_TMPL
##############################################

# Add prep_marine_obs.py to PYTHONPATH
export PYTHONPATH=${HOMEgfs}/sorc/gdas.cd/ush/soca:${PYTHONPATH}
export PYTHONPATH=${HOMEgfs}/sorc/gdas.cd/ush:${PYTHONPATH}

###############################################################
# Run relevant script
Expand All @@ -38,7 +38,7 @@ if [[ -e "${pgmout}" ]] ; then
fi

##########################################
# Handle the temporary working directory
# Handle the temporary working directory
##########################################
cd "${DATAROOT}" || (echo "FATAL ERROR: ${DATAROOT} does not exist. ABORT!"; exit 1)
[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}"
Expand Down
1 change: 1 addition & 0 deletions parm/config/gfs/config.base.emc.dyn
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ export binary_diag=".false."
# Verification options
export DO_METP="NO" # Run METPLUS jobs - set METPLUS settings in config.metp; not supported with spack-stack
export DO_FIT2OBS="YES" # Run fit to observations package
export DO_VRFY_OCEANDA="NO" # Run SOCA Ocean DA verification tasks

# Archiving options
export HPSSARCH="@HPSSARCH@" # save data to HPSS archive
Expand Down
10 changes: 9 additions & 1 deletion parm/config/gfs/config.ocn
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ if [[ "${DO_JEDIOCNVAR}" == "YES" ]]; then
else
export ODA_INCUPD="False"
fi
export ODA_INCUPD_NHOURS="3.0" # In MOM_input, this is time interval for applying increment

# Time interval for applying the increment
if [[ "${DOIAU}" == "YES" ]]; then
export ODA_INCUPD_NHOURS="6.0"
else
export ODA_INCUPD_NHOURS="3.0"
fi



echo "END: config.ocn"
17 changes: 12 additions & 5 deletions parm/config/gfs/config.resources
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ case ${step} in
export npe_prepoceanobs=1
export nth_prepoceanobs=1
export npe_node_prepoceanobs=$(( npe_node_max / nth_prepoceanobs ))
export memory_prepoceanobs="24GB"
export memory_prepoceanobs="48GB"
;;

"ocnanalbmat")
Expand Down Expand Up @@ -406,13 +406,20 @@ case ${step} in
export nth_ocnanalchkpt=1
export npe_node_ocnanalchkpt=$(( npe_node_max / nth_ocnanalchkpt ))
case ${CASE} in
"C384") memory_ocnanalchkpt="128GB";;
"C96") memory_ocnanalchkpt="32GB";;
"C48") memory_ocnanalchkpt="32GB";;
"C384")
memory_ocnanalchkpt="128GB"
npes=40;;
"C96")
memory_ocnanalchkpt="32GB"
npes=16;;
"C48")
memory_ocnanalchkpt="32GB"
npes=8;;
*)
echo "FATAL ERROR: Resources not defined for job ${job} at resolution ${CASE}"
exit 4
esac
export npe_ocnanalchkpt=${npes}
export memory_ocnanalchkpt
;;

Expand Down Expand Up @@ -926,7 +933,7 @@ case ${step} in
export nth_eupd=4
fi
;;
*)
*)
echo "FATAL ERROR: Resources not defined for job ${job} at resolution ${CASE}"
exit 4
;;
Expand Down
13 changes: 7 additions & 6 deletions parm/config/gfs/yaml/defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ landanl:
IO_LAYOUT_Y: 1

ocnanal:
SOCA_INPUT_FIX_DIR: "/scratch2/NCEPDEV/ocean/Guillaume.Vernieres/data/static/72x35x25/soca" # TODO: These need to go to glopara fix space. @guillaumevernieres will open an issue
CASE_ANL: "C48"
COMIN_OBS: "/scratch2/NCEPDEV/marineda/r2d2-v2-v3" # TODO: make platform agnostic
SOCA_OBS_LIST: "{{ HOMEgfs }}/sorc/gdas.cd/parm/soca/obs/obs_list.yaml"
SOCA_INPUT_FIX_DIR: "/scratch2/NCEPDEV/ocean/Guillaume.Vernieres/data/static/72x35x25/soca" # TODO: These need to go to glopara fix space.
CASE_ANL: "C48" # TODO: Check in gdasapp if used anywhere for SOCA
SOCA_OBS_LIST: "{{ HOMEgfs }}/sorc/gdas.cd/parm/soca/obs/obs_list.yaml" # TODO: This is also repeated in oceanprepobs
SOCA_NINNER: 100
R2D2_OBS_SRC: "gdas_marine"
R2D2_OBS_DUMP: "s2s_v1"
SABER_BLOCKS_YAML: ""
NICAS_RESOL: 1
NICAS_GRID_SIZE: 15000
prepoceanobs:
SOCA_OBS_LIST: "{{ HOMEgfs }}/sorc/gdas.cd/parm/soca/obs/obs_list.yaml" # TODO: This is also repeated in ocnanal
OBSPREP_YAML: "{{ HOMEgfs }}/sorc/gdas.cd/parm/soca/obsprep/obsprep_config.yaml"
DMPDIR: "/scratch1/NCEPDEV/global/glopara/data/experimental_obs"
11 changes: 7 additions & 4 deletions workflow/applications/gfs_cycled.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def __init__(self, conf: Configuration):
self.do_jediocnvar = self._base.get('DO_JEDIOCNVAR', False)
self.do_jedilandda = self._base.get('DO_JEDILANDDA', False)
self.do_mergensst = self._base.get('DO_MERGENSST', False)
self.do_vrfy_oceanda = self._base.get('DO_VRFY_OCEANDA', False)

self.lobsdiag_forenkf = False
self.eupd_cdumps = None
Expand All @@ -43,8 +44,9 @@ def _get_app_configs(self):

if self.do_jediocnvar:
configs += ['prepoceanobs', 'ocnanalprep', 'ocnanalbmat',
'ocnanalrun', 'ocnanalchkpt', 'ocnanalpost',
'ocnanalvrfy']
'ocnanalrun', 'ocnanalchkpt', 'ocnanalpost']
if self.do_vrfy_oceanda:
configs += ['ocnanalvrfy']

if self.do_ocean:
configs += ['ocnpost']
Expand Down Expand Up @@ -137,8 +139,9 @@ def get_task_names(self):
if self.do_jediocnvar:
gdas_gfs_common_tasks_before_fcst += ['prepoceanobs', 'ocnanalprep',
'ocnanalbmat', 'ocnanalrun',
'ocnanalchkpt', 'ocnanalpost',
'ocnanalvrfy']
'ocnanalchkpt', 'ocnanalpost']
if self.do_vrfy_oceanda:
gdas_gfs_common_tasks_before_fcst += ['ocnanalvrfy']

gdas_gfs_common_tasks_before_fcst += ['sfcanl', 'analcalc']

Expand Down
7 changes: 7 additions & 0 deletions workflow/setup_expt.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,13 @@ def link_files_from_src_to_dst(src_dir, dst_dir):
src_file = os.path.join(src_dir, fname)
if os.path.exists(src_file):
os.symlink(src_file, os.path.join(dst_dir, fname))
# First 1/2 cycle also needs a atmos increment if doing warm start
if inputs.start in ['warm']:
for ftype in ['atmi003.nc', 'atminc.nc', 'atmi009.nc']:
aerorahul marked this conversation as resolved.
Show resolved Hide resolved
fname = f'{inputs.cdump}.t{idatestr[8:]}z.{ftype}'
src_file = os.path.join(src_dir, fname)
if os.path.exists(src_file):
os.symlink(src_file, os.path.join(dst_dir, fname))

return

Expand Down
Loading