BASH GitHub CLI version of High Resolution cases used for CI weekly tests #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… high resolution C384 cases
…orkflow into develop
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TerrenceMcGuinness-NOAA
changed the title
TerrenceMcGuinness-NOAA
requested review from
aerorahul and
WalterKolczynski-NOAA
TerrenceMcGuinness-NOAA
changed the title
TerrenceMcGuinness-NOAA
changed the title
WalterKolczynski-NOAA
requested changes
Sep 20, 2023
aerorahul
requested changes
Sep 20, 2023
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
aerorahul
reviewed
Sep 20, 2023
aerorahul
reviewed
Sep 20, 2023
… remove temp files for the git push
Co-authored-by: Rahul Mahajan <[email protected]>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
aerorahul
reviewed
Sep 20, 2023
ci/scripts/driver_weekly.sh
Outdated
|
|
||
| rm -Rf "${HOMEgfs_PR}/ci/cases/pr" | ||
| mv "${HOMEgfs_PR}/ci/cases/weekly" "${HOMEgfs_PR}/ci/cases/pr" | ||
| cd "${HOMEgfs_PR}" || exit 1 |
There was a problem hiding this comment.
I think we are already in ${HOMEgfs_PR}. There is no need to cd into it again.
…ness-NOAA/global-workflow into feature/bash_weekly_pr_CI
aerorahul
reviewed
Sep 20, 2023
| do | ||
| "${GH}" pr edit --add-label "${label}" | ||
| done | ||
| rm -Rf "${develop_dir}" |
There was a problem hiding this comment.
The script may have trouble removing this directory as it is presently in that CWD/global-workflow.
There was a problem hiding this comment.
Oh right, it should work because the shell quits on return, but yeah it's not a good idea.
move off of directory that is being removed at the end of the driver_weekly bash script
aerorahul
approved these changes
Sep 21, 2023
WalterKolczynski-NOAA
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A BASH script using GitHub CLI is added to create a branch from develop named weekly_tests and moves the cases from
$HOMEgfs/ci/cases/weeklyto$HOMEgfs/ci/cases/prand then opens a PR and labels it with CI-Hera-Ready and CI-Orion-Ready thus creating a weekly high resolution test run that can easily be launched by a cron job.Resolves #1663
Type of change
Tests Ran
weekly_tests.shand successfully create PR with labels and new cases in pr directoryChecklist