Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ufs-weather-model hash #1862

Closed

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Sep 15, 2023

Description

This PR simply updates the hash of the ufs-weather-model.
Tagging @NeilBarton-NOAA @bingfu-NOAA @rmontuoro for awareness

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? No
  • Does this change require a documentation update? No

How has this been tested?

CI testing should suffice.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@aerorahul aerorahul added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Sep 15, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Sep 15, 2023
@aerorahul aerorahul changed the title Update ufs-weather-model hash for GEFS users Update ufs-weather-model hash Sep 15, 2023
@JessicaMeixner-NOAA
Copy link
Contributor

JessicaMeixner-NOAA commented Sep 15, 2023

Looks like there are some settings updates that should go along with the hash update when looking at the compare: ufs-community/ufs-weather-model@GFSv17.HR2...develop

Editing to add the section where I think we might be missing updates that we'll want.
Screenshot 2023-09-15 at 2 03 06 PM

@aerorahul
Copy link
Contributor Author

Looks like there are some settings updates that should go along with the hash update when looking at the compare: ufs-community/[email protected]

Editing to add the section where I think we might be missing updates that we'll want. Screenshot 2023-09-15 at 2 03 06 PM

Thank you @JessicaMeixner-NOAA
Would you recommend I hold off on updating the hash until a more complete update is available?

@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Sep 15, 2023
@emcbot
Copy link

emcbot commented Sep 15, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Sep 15 12:48:21 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Sep 15 12:50:26 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Sep 15 13:18:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:18 CDT 2023 for experiment C48_ATM_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:22 CDT 2023 for experiment C48_S2SA_gefs_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:26 CDT 2023 for experiment C48_S2S_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:30 CDT 2023 for experiment C96_atm3DVar_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:34 CDT 2023 for experiment C96C48_hybatmDA_f95ca92b

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Sep 15, 2023
@emcbot
Copy link

emcbot commented Sep 15, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Fri Sep 15 17:49:07 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Sep 15 17:54:43 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Fri Sep 15 18:19:50 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:19:53 UTC 2023 for experiment C48_ATM_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:19:56 UTC 2023 for experiment C48_S2S_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:19:59 UTC 2023 for experiment C48_S2SA_gefs_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:20:02 UTC 2023 for experiment C96C48_hybatmDA_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:20:06 UTC 2023 for experiment C96_atm3DVar_f95ca92b

@emcbot emcbot added CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Sep 15, 2023
@emcbot
Copy link

emcbot commented Sep 15, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Sep 15 12:48:21 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Sep 15 12:50:26 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Sep 15 13:18:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:18 CDT 2023 for experiment C48_ATM_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:22 CDT 2023 for experiment C48_S2SA_gefs_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:26 CDT 2023 for experiment C48_S2S_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:30 CDT 2023 for experiment C96_atm3DVar_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 13:18:34 CDT 2023 for experiment C96C48_hybatmDA_f95ca92b
Experiment C48_S2SA_gefs_f95ca92b Terminated: *FAILED*
Experiment C48_S2SA_gefs_f95ca92b Terminated with 3 tasks failed at Fri Sep 15 13:30:34 CDT 2023
Error logs:
/work2/noaa/stmp/GFS_CI_ROOT/PR/1862/RUNTESTS/COMROT/C48_S2SA_gefs_f95ca92b/logs/2021032312/gefsefcs01.log
/work2/noaa/stmp/GFS_CI_ROOT/PR/1862/RUNTESTS/COMROT/C48_S2SA_gefs_f95ca92b/logs/2021032312/gefsefcs02.log
/work2/noaa/stmp/GFS_CI_ROOT/PR/1862/RUNTESTS/COMROT/C48_S2SA_gefs_f95ca92b/logs/2021032312/gefsfcst.log

@JessicaMeixner-NOAA
Copy link
Contributor

@aerorahul I think we should. More details can be seen here : #1811 and hopefully @DeniseWorthen can weigh in on this as well.

@aerorahul
Copy link
Contributor Author

@aerorahul I think we should. More details can be seen here : #1811 and hopefully @DeniseWorthen can weigh in on this as well.

Sounds good.
I will close this PR and let the appropriate teams open a PR with all the relevant changes necessary for consistent model configurations.

@aerorahul aerorahul closed this Sep 15, 2023
@aerorahul aerorahul deleted the feature/update-ufs-hash branch September 15, 2023 19:40
@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Sep 16, 2023
@emcbot
Copy link

emcbot commented Sep 16, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Fri Sep 15 17:49:07 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Sep 15 17:54:43 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Fri Sep 15 18:19:50 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:19:53 UTC 2023 for experiment C48_ATM_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:19:56 UTC 2023 for experiment C48_S2S_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:19:59 UTC 2023 for experiment C48_S2SA_gefs_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:20:02 UTC 2023 for experiment C96C48_hybatmDA_f95ca92b
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Sep 15 18:20:06 UTC 2023 for experiment C96_atm3DVar_f95ca92b
Experiment C48_ATM_f95ca92b Terminated: *FAILED*
Experiment C48_ATM_f95ca92b Terminated with 1 tasks failed at Sat Sep 16 00:18:17 UTC 2023
Error logs:
/scratch1/NCEPDEV/global/Terry.McGuinness/GFS_CI_ROOT/PR/1862/RUNTESTS/COMROT/C48_ATM_f95ca92b/logs/2021032312/gfsfcst.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants