-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jjob stub for prospective ocean analysis prep observation task #1831
Add jjob stub for prospective ocean analysis prep observation task #1831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good.
See specific comments inline.
Missing is a jobs/rocoto/prepoceanobs.sh
@@ -0,0 +1,43 @@ | |||
#!/bin/bash | |||
export STRICT="NO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this NO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an outstanding issue with variables not getting assigned (I suspect because we don't use them) - this is being worked on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,43 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets call this job:
JGLOBAL_PREP_OCEAN_OBS
to be consistent with how jobs are named.
This job will be called for both gdas
and gfs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
# Ignore possible spelling error (nothing is misspelled) | ||
# shellcheck disable=SC2153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is being ignored?
# Ignore possible spelling error (nothing is misspelled) | |
# shellcheck disable=SC2153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@@ -0,0 +1,10 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer this config to be config.prepoceanobs
We currently have config.prep
Newer components would be config.prep<component>obs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update elsewhere as necessary.
@aerorahul Thanks for the input - I'll get to it next week. |
fi | ||
|
||
########################################## | ||
# Do not remove the Temporary working directory (do this in POST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Do not remove the Temporary working directory (do this in POST) | |
# Remove the temporary working directory |
Probably a residual from a previous copy-paste.
We do wan't to remove job specific run directories at the end of the job.
########################################## | ||
# Do not remove the Temporary working directory (do this in POST) | ||
########################################## | ||
cd "${DATAROOT}" || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do want to remove the data directory at the end of the job.
cd "${DATAROOT}" || exit 1 | |
cd "${DATAROOT}" || (echo "FATAL ERROR: ${DATAROOT} does not exist. ABORT!"; exit 1) | |
[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}" |
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
…NOAA/global-workflow into feature/add-ocn-prep-obs
New version @guillaumevernieres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Description
Adds jjob and basic infrastructure for WCDA observation prep task, which will copy and process observations for the coupled ocean analysis. This is an initial addition, only a stub, to facilitate development of scripts that will do the work.
Partially resolves NOAA-EMC/GDASApp#579 and NOAA-EMC/GDASApp#590
Type of change
Change characteristics
How has this been tested?
Tested with GDASApp soca ctests in GDASApp branch feature/prepocniodaobs on Hera
Checklist