-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to get C48 aerosol test ready #1829
Changes to get C48 aerosol test ready #1829
Conversation
#1826 will depend on this as it will need the updated GDASApp hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Cloned CoryMartin-NOAA:feature/aero3dvar_test1
on Orion and will run test_gdasapp
after building GDASApp.
Tentative approve.
@CoryMartin-NOAA ,
Obviously, |
@RussTreadon-NOAA thanks, good catch, this is because I forgot to copy the new ob file that @andytangborn created to orion, I only put it on Hera. It should be updated now, all three (init, run, final) will need to be re-ran to confirm. |
Thank you @CoryMartin-NOAA for the quick fix. The
Reran the final job with
My
I can't update a file which you own. |
@RussTreadon-NOAA ah! this is why we have independent tests! So it needs to be a cp and not a symlink it seems. |
Tinkered with
With this change all three aero tests Passed
|
Pull in updated hash and rerun
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Description
This PR partially addresses #1821 in that it allows for a C48 simplified aerosol 3DVar test using the workflow to run in GDASApp CI testing. The workflow team will be able to adapt this test case for their CI testing with minimal effort.
This limits the C48 aerosol analysis to 6 PEs and updates the hash of GDASApp to a stable build from this morning.
Type of change
Change characteristics
How has this been tested?
Built and tested on Hera
Checklist