Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to doc build action for PRs #1809

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

Description

A path filter was applied to pushes, but none was applied to PRs, causing the GH action to build documentation to fire every time a PR is opened or updated.

Resolves #1791

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This should work, but won't know for sure until it is merged. When using pull_request_target, the base branch is used for actions (see https://github.com/orgs/community/discussions/27084)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

A path filter was applied to pushes, but none was applied to PRs,
causing the GH action to build documentation to fire every time a
PR is opened or updated.

Resolves #1791
@github-actions
Copy link

Link to ReadTheDocs sample build for this PR can be found at:
https://global-workflow--1809.org.readthedocs.build/en/1809

Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work ... glad you did this, those constant messages with the link I set up where getting annoying, I should have thought of this myself when I started to see them.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get this in ASAP.

@aerorahul aerorahul merged commit 1f8bf78 into develop Aug 25, 2023
8 checks passed
@aerorahul aerorahul deleted the feature/rtd_link_changed branch August 25, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only post RTD link on PRs if docs have changed
3 participants