Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BASH wrapper to create_experiment.py and removed its redundant 2nd argument #1789

Closed
wants to merge 5 commits into from
Closed

BASH wrapper to create_experiment.py and removed its redundant 2nd argument #1789

wants to merge 5 commits into from

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

Description*

Adding BASH wrapper to create_experiment.py so users can use it directly (it previously needed several environments settings found in ../platforms/${MACHINE}.sh). Also removed redundant argument the python script.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This was tested by creating experiments with only the needed arguments and checked them with $HOMEgfs/workflow/test_configuration.py

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@TerryMcGuinness-NOAA
added BASH wrapper to create experiment and removed redundent second …
42ba930 
…argument
@TerrenceMcGuinness-NOAA
Update create_experiment.sh
a42e9e1 
removed second source to platform
@TerrenceMcGuinness-NOAA
Update create_experiment.sh
bc9589f 
removed old message about running tests
@TerrenceMcGuinness-NOAA
Update create_experiment.sh
68b5438 
bash linting
@TerrenceMcGuinness-NOAA
Update create_experiment.sh
114512a 
BASH double quote linting
@NOAA-EMC NOAA-EMC deleted a comment from github-actions bot Aug 10, 2023
@NOAA-EMC NOAA-EMC deleted a comment from github-actions bot Aug 10, 2023
@github-actions
Copy link

Link to ReadTheDocs sample build for this PR can be found at:
https://global-workflow--1789.org.readthedocs.build/en/1789

@NOAA-EMC NOAA-EMC deleted a comment from github-actions bot Aug 10, 2023
@NOAA-EMC NOAA-EMC deleted a comment from github-actions bot Aug 10, 2023
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI/CD Issue related to CI/CD labels Aug 10, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Aug 10, 2023
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Aug 10, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Aug 10, 2023
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title BASH wrapper to create experiment and removed its redundant second argument BASH wrapper to create_experiment.py and removed its redundant 2nd argument Aug 10, 2023
@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Aug 10, 2023
@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8

@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8
Experiment C48_S2S_114512a8 completed: *SUCCESS*
Experiment C48_S2S_114512a8 Completed at Thu Aug 10 14:54:14 CDT 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8
Experiment C48_S2S_114512a8 completed: *SUCCESS*
Experiment C48_S2S_114512a8 Completed at Thu Aug 10 14:54:14 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_114512a8 completed: *SUCCESS*
Experiment C48_ATM_114512a8 Completed at Thu Aug 10 15:18:15 CDT 2023
with 48 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8
Experiment C48_S2S_114512a8 completed: *SUCCESS*
Experiment C48_S2S_114512a8 Completed at Thu Aug 10 14:54:14 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_114512a8 completed: *SUCCESS*
Experiment C48_ATM_114512a8 Completed at Thu Aug 10 15:18:15 CDT 2023
with 48 successfully completed jobs
Experiment C48_S2SA_gefs_114512a8 completed: *SUCCESS*
Experiment C48_S2SA_gefs_114512a8 Completed at Thu Aug 10 15:30:31 CDT 2023
with 3 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 10, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8
Experiment C48_S2S_114512a8 completed: *SUCCESS*
Experiment C48_S2S_114512a8 Completed at Thu Aug 10 14:54:14 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_114512a8 completed: *SUCCESS*
Experiment C48_ATM_114512a8 Completed at Thu Aug 10 15:18:15 CDT 2023
with 48 successfully completed jobs
Experiment C48_S2SA_gefs_114512a8 completed: *SUCCESS*
Experiment C48_S2SA_gefs_114512a8 Completed at Thu Aug 10 15:30:31 CDT 2023
with 3 successfully completed jobs
Experiment C96_atm3DVar_114512a8 completed: *SUCCESS*
Experiment C96_atm3DVar_114512a8 Completed at Thu Aug 10 18:54:34 CDT 2023
with 89 successfully completed jobs

@emcbot
Copy link

emcbot commented Aug 11, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8
Experiment C48_S2S_114512a8 completed: *SUCCESS*
Experiment C48_S2S_114512a8 Completed at Thu Aug 10 14:54:14 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_114512a8 completed: *SUCCESS*
Experiment C48_ATM_114512a8 Completed at Thu Aug 10 15:18:15 CDT 2023
with 48 successfully completed jobs
Experiment C48_S2SA_gefs_114512a8 completed: *SUCCESS*
Experiment C48_S2SA_gefs_114512a8 Completed at Thu Aug 10 15:30:31 CDT 2023
with 3 successfully completed jobs
Experiment C96_atm3DVar_114512a8 completed: *SUCCESS*
Experiment C96_atm3DVar_114512a8 Completed at Thu Aug 10 18:54:34 CDT 2023
with 89 successfully completed jobs
Experiment C96C48_hybatmDA_114512a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_114512a8 Completed at Thu Aug 10 19:30:50 CDT 2023
with 151 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Aug 11, 2023
@emcbot
Copy link

emcbot commented Aug 11, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Aug 10 13:18:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Aug 10 13:20:23 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Aug 10 13:48:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:14 CDT 2023 for experiment C48_ATM_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:17 CDT 2023 for experiment C48_S2SA_gefs_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:20 CDT 2023 for experiment C48_S2S_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:23 CDT 2023 for experiment C96_atm3DVar_114512a8
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Aug 10 13:48:27 CDT 2023 for experiment C96C48_hybatmDA_114512a8
Experiment C48_S2S_114512a8 completed: *SUCCESS*
Experiment C48_S2S_114512a8 Completed at Thu Aug 10 14:54:14 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_114512a8 completed: *SUCCESS*
Experiment C48_ATM_114512a8 Completed at Thu Aug 10 15:18:15 CDT 2023
with 48 successfully completed jobs
Experiment C48_S2SA_gefs_114512a8 completed: *SUCCESS*
Experiment C48_S2SA_gefs_114512a8 Completed at Thu Aug 10 15:30:31 CDT 2023
with 3 successfully completed jobs
Experiment C96_atm3DVar_114512a8 completed: *SUCCESS*
Experiment C96_atm3DVar_114512a8 Completed at Thu Aug 10 18:54:34 CDT 2023
with 89 successfully completed jobs
Experiment C96C48_hybatmDA_114512a8 completed: *SUCCESS*
Experiment C96C48_hybatmDA_114512a8 Completed at Thu Aug 10 19:30:50 CDT 2023
with 151 successfully completed jobs

WalterKolczynski-NOAA
WalterKolczynski-NOAA reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is needed. Seems like it replaces a couple of simple option inputs (2 line deletions and 2 argument removals) and replaces it with an entire 68-line script. Also perhaps a step backwards as we push towards pythonization? (although there may certainly be time a shell script will be preferred).

Is there something I'm missing that this change simplifies?

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA marked this pull request as draft August 11, 2023 20:08
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA deleted the feature/bash_wrap_exp branch September 25, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA left review comments

Assignees
No one assigned
Labels
CI/CD Issue related to CI/CD CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully ON HOLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TerrenceMcGuinness-NOAA @emcbot @WalterKolczynski-NOAA @TerryMcGuinness-NOAA