Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UFS parm directories into parm/ufs/ #1767

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Move UFS parm directories into parm/ufs/ #1767

merged 3 commits into from
Jul 28, 2023

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jul 27, 2023 •
edited
Loading

Description
This PR:

  • moves parm/parm_fv3diag -> parm/ufs/fv3
  • moves parm/mom6 -> parm/ufs/mom6
  • moves parm/chem -> parm/ufs/chem
  • updates scripts referencing this updated path

Fixes #1510

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved pending CI testing.

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Move parm/ directories chem/ mom6/ parm_fv3diag/ into parm/ufs/ Move UFS parm directories into parm/ufs/ Jul 27, 2023
@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Jul 27, 2023
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jul 27, 2023
@emcbot
Copy link

emcbot commented Jul 27, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 27 22:00:30 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 22:04:27 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 22:29:39 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:43 UTC 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:45 UTC 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:48 UTC 2023 for experiment C96C48_hybatmDA_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:50 UTC 2023 for experiment C96_atm3DVar_eabd8d34

@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Jul 27, 2023
@emcbot
Copy link

emcbot commented Jul 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 27 17:00:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 17:02:40 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 17:33:17 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:26 CDT 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:31 CDT 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:38 CDT 2023 for experiment C96_atm3DVar_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:48 CDT 2023 for experiment C96C48_hybatmDA_eabd8d34

@emcbot
Copy link

emcbot commented Jul 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 27 17:00:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 17:02:40 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 17:33:17 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:26 CDT 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:31 CDT 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:38 CDT 2023 for experiment C96_atm3DVar_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:48 CDT 2023 for experiment C96C48_hybatmDA_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 18:16:15 CDT 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 27 17:00:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 17:02:40 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 17:33:17 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:26 CDT 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:31 CDT 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:38 CDT 2023 for experiment C96_atm3DVar_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:48 CDT 2023 for experiment C96C48_hybatmDA_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 18:16:15 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Thu Jul 27 18:46:09 CDT 2023
with 48 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 27, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 27 22:00:30 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 22:04:27 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 22:29:39 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:43 UTC 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:45 UTC 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:48 UTC 2023 for experiment C96C48_hybatmDA_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:50 UTC 2023 for experiment C96_atm3DVar_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 23:57:25 UTC 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 27 22:00:30 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 22:04:27 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 22:29:39 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:43 UTC 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:45 UTC 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:48 UTC 2023 for experiment C96C48_hybatmDA_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:50 UTC 2023 for experiment C96_atm3DVar_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 23:57:25 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Fri Jul 28 00:27:24 UTC 2023
with 48 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 27 17:00:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 17:02:40 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 17:33:17 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:26 CDT 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:31 CDT 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:38 CDT 2023 for experiment C96_atm3DVar_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:48 CDT 2023 for experiment C96C48_hybatmDA_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 18:16:15 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Thu Jul 27 18:46:09 CDT 2023
with 48 successfully completed jobs
Experiment C96_atm3DVar_eabd8d34 completed: *SUCCESS*
Experiment C96_atm3DVar_eabd8d34 Completed at Thu Jul 27 20:42:09 CDT 2023
with 89 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 27 17:00:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 17:02:40 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 17:33:17 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:26 CDT 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:31 CDT 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:38 CDT 2023 for experiment C96_atm3DVar_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:48 CDT 2023 for experiment C96C48_hybatmDA_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 18:16:15 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Thu Jul 27 18:46:09 CDT 2023
with 48 successfully completed jobs
Experiment C96_atm3DVar_eabd8d34 completed: *SUCCESS*
Experiment C96_atm3DVar_eabd8d34 Completed at Thu Jul 27 20:42:09 CDT 2023
with 89 successfully completed jobs
Experiment C96C48_hybatmDA_eabd8d34 completed: *SUCCESS*
Experiment C96C48_hybatmDA_eabd8d34 Completed at Thu Jul 27 21:06:13 CDT 2023
with 151 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Jul 28, 2023
@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 27 17:00:38 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 17:02:40 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 17:33:17 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:26 CDT 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:31 CDT 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:38 CDT 2023 for experiment C96_atm3DVar_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 17:33:48 CDT 2023 for experiment C96C48_hybatmDA_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 18:16:15 CDT 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Thu Jul 27 18:46:09 CDT 2023
with 48 successfully completed jobs
Experiment C96_atm3DVar_eabd8d34 completed: *SUCCESS*
Experiment C96_atm3DVar_eabd8d34 Completed at Thu Jul 27 20:42:09 CDT 2023
with 89 successfully completed jobs
Experiment C96C48_hybatmDA_eabd8d34 completed: *SUCCESS*
Experiment C96C48_hybatmDA_eabd8d34 Completed at Thu Jul 27 21:06:13 CDT 2023
with 151 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 27 22:00:30 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 22:04:27 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 22:29:39 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:43 UTC 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:45 UTC 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:48 UTC 2023 for experiment C96C48_hybatmDA_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:50 UTC 2023 for experiment C96_atm3DVar_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 23:57:25 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Fri Jul 28 00:27:24 UTC 2023
with 48 successfully completed jobs
Experiment C96C48_hybatmDA_eabd8d34 completed: *SUCCESS*
Experiment C96C48_hybatmDA_eabd8d34 Completed at Fri Jul 28 02:33:14 UTC 2023
with 151 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 27 22:00:30 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 22:04:27 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 22:29:39 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:43 UTC 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:45 UTC 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:48 UTC 2023 for experiment C96C48_hybatmDA_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:50 UTC 2023 for experiment C96_atm3DVar_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 23:57:25 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Fri Jul 28 00:27:24 UTC 2023
with 48 successfully completed jobs
Experiment C96C48_hybatmDA_eabd8d34 completed: *SUCCESS*
Experiment C96C48_hybatmDA_eabd8d34 Completed at Fri Jul 28 02:33:14 UTC 2023
with 151 successfully completed jobs
Experiment C96_atm3DVar_eabd8d34 completed: *SUCCESS*
Experiment C96_atm3DVar_eabd8d34 Completed at Fri Jul 28 02:51:07 UTC 2023
with 89 successfully completed jobs

@emcbot emcbot removed the CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress label Jul 28, 2023
@emcbot emcbot added the CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully label Jul 28, 2023
@emcbot
Copy link

emcbot commented Jul 28, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 27 22:00:30 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 27 22:04:27 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 27 22:29:39 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:43 UTC 2023 for experiment C48_ATM_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:45 UTC 2023 for experiment C48_S2S_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:48 UTC 2023 for experiment C96C48_hybatmDA_eabd8d34
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 27 22:29:50 UTC 2023 for experiment C96_atm3DVar_eabd8d34
Experiment C48_S2S_eabd8d34 completed: *SUCCESS*
Experiment C48_S2S_eabd8d34 Completed at Thu Jul 27 23:57:25 UTC 2023
with 18 successfully completed jobs
Experiment C48_ATM_eabd8d34 completed: *SUCCESS*
Experiment C48_ATM_eabd8d34 Completed at Fri Jul 28 00:27:24 UTC 2023
with 48 successfully completed jobs
Experiment C96C48_hybatmDA_eabd8d34 completed: *SUCCESS*
Experiment C96C48_hybatmDA_eabd8d34 Completed at Fri Jul 28 02:33:14 UTC 2023
with 151 successfully completed jobs
Experiment C96_atm3DVar_eabd8d34 completed: *SUCCESS*
Experiment C96_atm3DVar_eabd8d34 Completed at Fri Jul 28 02:51:07 UTC 2023
with 89 successfully completed jobs

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ff0778a into NOAA-EMC:develop Jul 28, 2023
4 checks passed
@aerorahul aerorahul deleted the feature/parm_ufs branch August 16, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename parm_fv3diag
3 participants
@aerorahul @emcbot @WalterKolczynski-NOAA