Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parm_gdas as gdas #1766

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

aerorahul
Copy link
Contributor

Description
This PR:

  • renames parm_gdas as gdas
  • updates JEDI analysis scripts to use this update.

There is no update needed in GDASApp.

Resolves #1511

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?
There are no CI tests for the GDASapp.
In principle, if this change works for one app, it should work for all.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test (yet) but changes look straightforward and correct.

@aerorahul
Copy link
Contributor Author

I did not test (yet) but changes look straightforward and correct.

Thanks for the review @CoryMartin-NOAA
Is it ok if we merge this or do you wish to test it before the merge?

@aerorahul
Copy link
Contributor Author

Got the 👍🏾 from @CoryMartin-NOAA to merge.

@aerorahul aerorahul merged commit 0493371 into NOAA-EMC:develop Jul 27, 2023
4 checks passed
@aerorahul aerorahul deleted the feature/issue1511 branch July 27, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename parm_gdas directory
3 participants