Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field table missing newline at EOF #1765

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

bingfu-NOAA
Copy link
Contributor

@bingfu-NOAA bingfu-NOAA commented Jul 27, 2023

Description
Two field tables has \n missing. This can lead to one of the lines is missing when the field table is rebuilt for aerosol applications. And one of the impacts is large bias of sea salt concentration for aerosol applications.
This PR is to fix two field table files that missing \n

Resolves #1764

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Forecast-only test on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@aerorahul
Copy link
Contributor

Just getting a confirmation from @JessicaMeixner-NOAA

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title fix field table missing \n Fix field table missing newline at EOF Jul 27, 2023
@JessicaMeixner-NOAA
Copy link
Contributor

Just getting a confirmation from @JessicaMeixner-NOAA

I think @NeilBarton-NOAA would be a better person to confirm this particular update.

@aerorahul
Copy link
Contributor

Just getting a confirmation from @JessicaMeixner-NOAA

I think @NeilBarton-NOAA would be a better person to confirm this particular update.

Ok. I just requested you since you added these files in #1197

@aerorahul aerorahul merged commit 5ee225a into NOAA-EMC:develop Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing \n in two field tables
4 participants