Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ush/soca to ocean vrfy pythonpath #1762

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Add ush/soca to ocean vrfy pythonpath #1762

merged 1 commit into from
Jul 24, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Description

Adds ush/soca to pythonpath in ocean vrfy task jjob in anticipation of python code to be added to said subdirectory

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with GDASApp global-workflow ctests on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@AndrewEichmann-NOAA
Copy link
Contributor Author

FYI @guillaumevernieres

guillaumevernieres
guillaumevernieres approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Thanks @AndrewEichmann-NOAA .

WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for now.

aerorahul
aerorahul approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@WalterKolczynski-NOAA
Copy link
Contributor

Bypassing CI tests since the system does not excercise this job yet.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 03c33b5 into NOAA-EMC:develop Jul 24, 2023
4 checks passed
@AndrewEichmann-NOAA
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewEichmann-NOAA @WalterKolczynski-NOAA @aerorahul @guillaumevernieres