Support coupled GEFS forecast, use mem000 for GEFS control #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the necessary updates to allow the workflow to run (non-wave) coupled forecasts. Some of the coupled functions in postdet had to be updated because they only checked for gfs and gdas runs, so necessary code was never executed. Also updates so that the GEFS control uses `mem000` as the memdir so it appears at the same level as the perturbed members. Relatedly, the default member number in coupled files is changed to 000 instead of 01. Finally, an unrelated error in the earc job is corrected where a character from the middle of the line was moved to the beginning. Resolves NOAA-EMC#1754
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Low-res test pass. C384 fails for a reason that seems unrelated (I tried develop and it failed too). |
aerorahul
requested changes
Jul 18, 2023
There was a problem hiding this comment.
looks better.
A couple of questions:
- see the review
- can we just link the
config.XYZfiles inparm/config/gefsfromparm/config/gfsthat are not different? I don't imagine things likeconfig.ocn,config.ice,config.ufs,config.waveto be different. These are setting the various properties of the model for a choice of resolution andwavgrdset inconfig.base.
parm/config/gefs/config.wave
Outdated
| @@ -0,0 +1,202 @@ | |||
| #! /usr/bin/env bash | |||
There was a problem hiding this comment.
Can we just link to config.wave from parm/config/gfs? Is there any distinction for wave between gfs and gefs for waves?
There was a problem hiding this comment.
Not sure if we will need to use different settings for GEFS. Can certain do that (and for aero/ice/ocn) until such time as we find we need to have different settings. Will leave it up to you.
There was a problem hiding this comment.
I would prefer to link in gefs to force them to be the same as gfs and really understand the requirements when they are presented why they need to be different. Otherwise there will be a tendency to just cram gefs specifics into this application.
I am not against the flexibility, but I would like to understand the reason and justification when that is provided.
This does not prevent us from maintaining a separate configuration for GEFS in the future.
There was a problem hiding this comment.
Done.
aerorahul
reviewed
Jul 18, 2023
Since the files are identical replace the component config files for GEFS with links to the GFS versions. Refs NOAA-EMC#1754
aerorahul
reviewed
Jul 20, 2023
| @@ -0,0 +1,29 @@ | |||
| #! /usr/bin/env bash | |||
There was a problem hiding this comment.
This can also be linked from parm/config/gfs
aerorahul
approved these changes
Jul 20, 2023
Took care of this one. |
WalterKolczynski-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Orion-Building
emcbot
added
the
CI-Hera-Running
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Orion-Running
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Orion-Passed
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
1 similar comment
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Hera-Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the necessary updates to allow the workflow to run (non-wave) coupled forecasts. Some of the coupled functions in postdet had to be updated because they only checked for gfs and gdas runs, so necessary code was never executed.
Also updates so that the GEFS control uses
mem000as the memdir so it appears at the same level as the perturbed members. Relatedly, the default member number in coupled files is changed to 000 instead of 01.Finally, an unrelated error in the earc job is corrected where a character from the middle of the line was moved to the beginning.
Resolves #1754
Type of change
Checklist