Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SDATE_GFS #1749

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Address SDATE_GFS #1749

merged 1 commit into from
Jul 17, 2023

Conversation

aerorahul
Copy link
Contributor

Description
Fixes #1748

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
The regular CI tests will not catch this as METP requires to be run for a few cycles.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested proposed change in Hera EXPDIR. Change works as it should. The correct format SDATE_GFS was written to the EXPDIR xml file.

Approve.

@RussTreadon-NOAA
Copy link
Contributor

Thank you @aerorahul for the quick response. The change works!

@aerorahul aerorahul merged commit e95228c into develop Jul 17, 2023
5 checks passed
@aerorahul aerorahul deleted the bugfix/1748 branch July 17, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDATE_GFS written to xml using incorrect format
2 participants