Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS cpu info to resources #1728

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Add AWS cpu info to resources #1728

merged 3 commits into from
Jul 6, 2023

Conversation

HenryRWinterbottom
Copy link
Contributor

@HenryRWinterbottom HenryRWinterbottom commented Jul 6, 2023

Description

Partition name and node size for AWS were missing from config.resources. This information has now been added.

Resolves #1727

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The script workflow/setup_xml.py completes successfully. CI has not been implement for NOAA CSPs. Manual testing was successful.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Bug/missing csp cpuinfo Add AWS cpu info to resources Jul 6, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit fe5ea7a into NOAA-EMC:develop Jul 6, 2023
8 checks passed
@HenryRWinterbottom HenryRWinterbottom deleted the bug/missing_csp_cpuinfo branch July 13, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing NOAA CSP AWS cpu information.
2 participants