Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fit2obs for COM refactor #1719

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Update fit2obs for COM refactor #1719

merged 8 commits into from
Jul 14, 2023

Commits on Jul 13, 2023

  1. Update fit2obs for COM refactor 

    Updated the fit2obs j-job for COM refactor. Logs show some failed copies
due to non-existant files, but not sure if those are related.

Fixes NOAA-EMC#1486
    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2fbe399 View commit details
    Browse the repository at this point in the history

  2. Shellcheck updates for fit2obs j-job

    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    415455f View commit details
    Browse the repository at this point in the history

  3. Fix path of history files for fit2obs archive 

    The archive job was using the incorrect source path for the history
files when copying to the local archive for fit2obs.

Refs: NOAA-EMC#1486
    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fd0aef6 View commit details
    Browse the repository at this point in the history

  4. Turn fit2obs back on by default 

    Fit2obs had been turned off during the COM refactor because it had
not yet been updated for the new paths. Now that the job has been
updated, it can be turned back on.

Refs: NOAA-EMC#1486
    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    404fd0d View commit details
    Browse the repository at this point in the history

  5. Add comment about why fit2obs variable name not updated

    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    50ab97b View commit details
    Browse the repository at this point in the history

  6. Remove intermediary COM variables in fit2obs

    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8147d5e View commit details
    Browse the repository at this point in the history

  7. Fix shellcheck complaint

    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    62c6533 View commit details
    Browse the repository at this point in the history

  8. Ignore shellcheck complaint

    @WalterKolczynski-NOAA
    WalterKolczynski-NOAA committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fee5e03 View commit details
    Browse the repository at this point in the history