Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snow DA cycling for the fractional grid setting. #1687

Merged
merged 17 commits into from
Jul 20, 2023
Merged

Update snow DA cycling for the fractional grid setting. #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b325dd9
Update snow DA cycling for the fractional grid setting.
jiaruidong2017 Jun 9, 2023
c8a95bd
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jun 15, 2023
3a5471f
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jun 23, 2023
1f112a5
Revert some changes.
jiaruidong2017 Jun 25, 2023
d8ee611
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jul 7, 2023
9c3b923
Update the GDASApp stable-nightly commit hash.
jiaruidong2017 Jul 7, 2023
e1369c4
Remove FRAC_GRID and FRAC_GRID=.false. option.
jiaruidong2017 Jul 7, 2023
0f9e265
Add FRAC_GRID back for apply_jedi_incr option.
jiaruidong2017 Jul 7, 2023
7e999b6
Update the GDASApp stable-nightly commit hash.
jiaruidong2017 Jul 9, 2023
469680f
Fix python path issue.
jiaruidong2017 Jul 10, 2023
962d310
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jul 10, 2023
6eb5850
Remove FRAC_GRID fro land_analysis.py.
jiaruidong2017 Jul 10, 2023
b3cdfa2
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jul 13, 2023
cb79ac8
Update the GDASApp commit hash for feature/stable-nightly.
jiaruidong2017 Jul 14, 2023
f30ac6b
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jul 15, 2023
c9d34bc
Merge branch 'develop' into feature/land_snodl
jiaruidong2017 Jul 19, 2023
882c263
Update the gdasapp's feature/stable-nightly to current.
jiaruidong2017 Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Externals.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ protocol = git
required = False

[GDASApp]
hash = 7e3d694
hash = fd8aa2f
local_path = sorc/gdas.cd
repo_url = https://github.com/NOAA-EMC/GDASApp.git
protocol = git
Expand Down
2 changes: 1 addition & 1 deletion jobs/rocoto/preplandobs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export jobid="${job}.$$"
###############################################################
# setup python path for workflow utilities and tasks
wxflowPATH="${HOMEgfs}/ush/python:${HOMEgfs}/ush/python/wxflow/src"
gdasappPATH="${HOMEgfs}/sorc/gdas.cd/iodaconv/src:${HOMEgfs}/sorc/gdas.cd/build/lib/python3.7/pyioda"
gdasappPATH="${HOMEgfs}/sorc/gdas.cd/iodaconv/src:${HOMEgfs}/sorc/gdas.cd/build/lib/python3.7"
PYTHONPATH="${PYTHONPATH:+${PYTHONPATH}:}${wxflowPATH}:${gdasappPATH}"
export PYTHONPATH

Expand Down
6 changes: 1 addition & 5 deletions parm/config/gfs/config.landanl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ export JEDIEXE="${HOMEgfs}/exec/fv3jedi_letkf.x"
export JEDIYAML="${HOMEgfs}/sorc/gdas.cd/parm/land/letkfoi/letkfoi.yaml"

# Ensemble member properties
if [[ "${FRAC_GRID}" = ".true." ]]; then
export SNOWDEPTHVAR="snodl"
elif [[ "${FRAC_GRID}" = ".false." ]]; then
export SNOWDEPTHVAR="snwdph"
fi
export SNOWDEPTHVAR="snodl"
export BESTDDEV="30." # Background Error Std. Dev. for LETKFOI

# Name of the executable that applies increment to bkg and its namelist template
Expand Down
2 changes: 1 addition & 1 deletion sorc/checkout.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ if [[ ${checkout_gsi} == "YES" ]]; then
fi

if [[ ${checkout_gdas} == "YES" ]]; then
checkout "gdas.cd" "https://github.com/NOAA-EMC/GDASApp.git" "7e3d694"; errs=$((errs + $?))
checkout "gdas.cd" "https://github.com/NOAA-EMC/GDASApp.git" "fd8aa2f"; errs=$((errs + $?))
fi

if [[ ${checkout_gsi} == "YES" || ${checkout_gdas} == "YES" ]]; then
Expand Down
6 changes: 2 additions & 4 deletions ush/python/pygfs/task/land_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,7 @@ def execute(self) -> None:
localconf = AttrDict()
keys = ['HOMEgfs', 'DATA', 'current_cycle',
'COM_ATMOS_RESTART_PREV', 'COM_LAND_ANALYSIS', 'APREFIX',
'SNOWDEPTHVAR', 'BESTDDEV',
'FRAC_GRID', 'CASE', 'ntiles',
'SNOWDEPTHVAR', 'BESTDDEV', 'CASE', 'ntiles',
'APRUN_LANDANL', 'JEDIEXE', 'jedi_yaml',
'APPLY_INCR_NML_TMPL', 'APPLY_INCR_EXE', 'APRUN_APPLY_INCR']
for key in keys:
Expand Down Expand Up @@ -383,7 +382,7 @@ def create_ensemble(vname: str, bestddev: float, config: Dict) -> None:
Parameters
----------
vname : str
snow depth variable to perturb. "snowdl" or "snwdph" depending on FRAC_GRID (.true.|.false.)
snow depth variable to perturb: "snodl"
bestddev : float
Background Error Standard Deviation to perturb around to create ensemble
config: Dict
Expand Down Expand Up @@ -432,7 +431,6 @@ def add_increments(config: Dict) -> None:
COM_ATMOS_RESTART_PREV
DATA
current_cycle
FRAC_GRID
CASE
ntiles
APPLY_INCR_NML_TMPL
Expand Down