Compress first[last]_mem logic and remove unused variable

Refs #2475
NOAA-EMC · Aug 13, 2024 · c6bb969 · c6bb969
1 parent 6659e72
commit c6bb969
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/ush/python/pygfs/task/stage_ic.py b/ush/python/pygfs/task/stage_ic.py
@@ -73,19 +73,16 @@ def configure(self, stage_dict: Dict[str, Any]) -> (Dict[str, Any]):
         stage_dict['rRUN'] = rRUN
 
         # Determine ensemble member settings
-        MEM_START = -1  # Deterministic default, no members
-        if self.task_config.NMEM_ENS > 0:
+        if self.task_config.NMEM_ENS > 0:  # Ensemble RUN
             if self.task_config.RUN == "gefs":
-                MEM_START = 0
+                stage_dict['first_mem'] = 0
+                stage_dict['last_mem'] = self.task_config.NMEM_ENS
             elif self.task_config.RUN == "enkfgdas":
-                MEM_START = 1
-
-        if MEM_START >= 0:  # Ensemble RUN
-            stage_dict['first_mem'] = MEM_START
-            stage_dict['last_mem'] = self.task_config.NMEM_ENS
-        else:  # Deteministic RUN
-            stage_dict['first_mem'] = MEM_START
-            stage_dict['last_mem'] = MEM_START
+                stage_dict['first_mem'] = 1
+                stage_dict['last_mem'] = self.task_config.NMEM_ENS
+        else:  # Deterministic RUN
+            stage_dict['first_mem'] = -1
+            stage_dict['last_mem'] = -1
 
         return stage_dict
 

diff --git a/workflow/rocoto/gefs_tasks.py b/workflow/rocoto/gefs_tasks.py
@@ -10,7 +10,6 @@ def __init__(self, app_config: AppConfig, run: str) -> None:
         super().__init__(app_config, run)
 
     def stage_ic(self):
-        cpl_ic = self._configs['stage_ic']
 
         resources = self.get_resource('stage_ic')
         task_name = f'stage_ic'

diff --git a/workflow/rocoto/gfs_tasks.py b/workflow/rocoto/gfs_tasks.py
@@ -20,8 +20,6 @@ def stage_ic(self):
 
         cycledef = 'gdas_half' if self.run in ['gdas', 'enkfgdas'] else self.run
 
-        cpl_ic = self._configs['stage_ic']
-
         resources = self.get_resource('stage_ic')
         task_name = f'{self.run}stage_ic'
         task_dict = {'task_name': task_name,