Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soil temperature and moisture IAU #866

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from

Conversation

tsga
Copy link

@tsga tsga commented Aug 27, 2024

Description

The atmospheric DA applies IAU increments on temperature (among other variables), while the land surface increments are applied once at the start of the DA (cycle?) window. This could lead to the land surface (soil and snow) temperature being out of sync with near surface atmospheric temperature

Issue(s) addressed

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Regression tests for ATM only and coupled (S2S) configurations pass in hera.

Additional land-IAU specific test to be added: control_c48_intel_land_iau (based on the "control_c48_intel" test, with the only difference being the turning on of land IAU and soil temperature increment files inside INPUT directory). The test inputs are at:
/scratch1/NCEPDEV/da/Tseganeh.Gichamo/ccpp-physics/test/control_c48_intel_land_iau

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

@tsga tsga reopened this Sep 16, 2024
@tsga
Copy link
Author

tsga commented Sep 16, 2024

Can't assign so tagging relevant people here. Please add (tag) anyone you think should be aware.
@CoryMartin-NOAA, @barlage, @ClaraDraper-NOAA, @CatherineThomas-NOAA, @junwang-noaa

@tsga tsga reopened this Oct 12, 2024
tsga and others added 25 commits October 17, 2024 12:39
… feature/lnd_iau

* 'feature/lnd_iau' of https://github.com/tsga/fv3atm:
  move weight factors to _IAU_Data
… feature/lnd_iau

* 'feature/lnd_iau' of https://github.com/tsga/fv3atm:
  update noahmpdrv meta
* develop:
  Update chunksizes for cubed sphere grid (NOAA-EMC#876)
  First reconciliation PR from production/RRFS.v1 (NOAA-EMC#872)
* develop:
  Second reconciliation PR from production/RRFSv1 (NOAA-EMC#881)
  STY: Use capital W and lowercase m for watts per square meter (NOAA-EMC#859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Land IAU Capability to NoahMP Driver in CCPP Add Land IAU Capability to NoahMP Driver in CCPP
3 participants