Refactor GFDLMP v1. Introduce GFDLMP v3. Fix initialization bug. #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce28fae.
|
@dustinswales I'd like to test this version. How do I check this code? Thanks! |
|
git clone --recursive --branch feature/gfdlmpv3 https://github.com/dustinswales/ufs-weather-model.git |
|
Dependency: ufs-community/ccpp-physics#195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains host side changes to accommodate a new cloud microphysics parameterization in the physics.
For the refactoring, all of the configuration/namelist info is moved into a common DDT that is referenced by both MP versions and a common fv_sat_adj.F90. There are default values for the scheme configurations defined within the schemes, and overwritten by the namelist, if provided. This is similar to how the GFS physics namelists are handled, BUT...since the namelist is read in during physics initialization, not at the model initialization, the default values don't get updated until we are in the physics group.
This is a problem, since fv_sat_adj is called before the physics from the dycore.
So at timestep=1, FV3 sees the default configuration for fv_sat_adj set in module_gfdl_cloud_microphysics, but then at physics timestep=1 fv_sat_adj is using the namelist updated configuration.
To fix this, as part of this PR the GFDL MP initialization is moved to the host (control_initialize).
Testing
Tested on Hera.
Changes in UFS RT baselines due to different (now correct) fv_sat_adj configuration seen at first timestep by dycore.
@RuiyuSun @yangfanglin